Skip to content

Conversation

@hossameldinmi
Copy link

@hossameldinmi hossameldinmi commented Oct 23, 2025

Implementing exists() and delete() functions for Native and HTML

A simple solution for this feature request, 177475

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements exists() and delete() methods for XFile on both native and web platforms. The changes include adding the method definitions to the base class, providing implementations for dart:io and dart:html, and adding corresponding tests. My review focuses on improving the correctness and readability of the web implementation.

@hossameldinmi hossameldinmi changed the title [cross_file] exists() and delete() file implemetation [cross_file] exists() and delete() file implementation Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant