Skip to content

Conversation

@jesswrd
Copy link
Contributor

@jesswrd jesswrd commented Oct 29, 2025

Updated the Gradle version formatting validation with a stricter regex. Previously passed on invalid versions.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Gradle version validation to use a more specific regular expression and provides a more detailed error message for invalid formats. The corresponding tests have been improved to cover more invalid version scenarios. While these changes are good, a new constant agpForExamples has been added but is not used anywhere in the command's logic, which should be addressed.

@jesswrd jesswrd changed the title update gradle regex format validation Update Gradle Version Formatting Validation Oct 29, 2025
@jesswrd jesswrd requested a review from a team October 30, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant