Skip to content

Conversation

@okorohelijah
Copy link
Contributor

In preparation of upgrading our fleet to macOS 15.7, allow tests to run on either macOS 15.5 or 15.7.

List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#176931

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CI configuration in .ci.yaml to modify the macOS versions for testing. It replaces Mac-14 with Mac-15.7, setting the target operating systems to Mac-15.5 or Mac-15.7. My review highlights that this change removes Mac-14 from the test matrix, which could create a gap in test coverage. I've suggested retaining Mac-14 to ensure continued support while adding the new version.

{"dependency": "ruby", "version": "ruby_3.1-pod_1.13"}
]
os: Mac-14|Mac-15.5
os: Mac-15.5|Mac-15.7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change removes Mac-14 from the list of operating systems for this test configuration. This could result in an unintended gap in test coverage for macOS 14. To ensure continued testing on the older OS while adding support for Mac-15.7, consider including all three versions.

      os: Mac-14|Mac-15.5|Mac-15.7

{"dependency": "ruby", "version": "ruby_3.1-pod_1.13"}
]
os: Mac-14|Mac-15.5
os: Mac-15.5|Mac-15.7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the change above, this removes Mac-14 from the test matrix for x86 CPUs. To maintain test coverage on macOS 14, it is advisable to add Mac-15.7 without removing the existing OS version.

      os: Mac-14|Mac-15.5|Mac-15.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update .ci.yaml in flutter/packages to use either macOS 15.5 or macOS 15.7.1

1 participant