From bc69344a3ae18472fcff7a531afa228889195ce5 Mon Sep 17 00:00:00 2001 From: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> Date: Tue, 11 Jul 2023 14:41:38 -0400 Subject: [PATCH 1/2] interface implementation --- .../webview_flutter_platform_interface/CHANGELOG.md | 5 +++++ .../lib/src/types/web_resource_error.dart | 4 ++++ .../webview_flutter_platform_interface/pubspec.yaml | 2 +- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md b/packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md index a407df5f5a04..b56ca80b706d 100644 --- a/packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md @@ -1,3 +1,8 @@ +## 2.4.0 + +* Adds support to retrieve the url from a web resource loading error. See + `WebResourceError.failingUrl`. + ## 2.3.1 * Removes obsolete null checks on non-nullable values. diff --git a/packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/web_resource_error.dart b/packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/web_resource_error.dart index e2522da859f7..cf0af4a4e703 100644 --- a/packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/web_resource_error.dart +++ b/packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/web_resource_error.dart @@ -107,6 +107,7 @@ class WebResourceError { required this.description, this.errorType, this.isForMainFrame, + this.url, }); /// Raw code of the error from the respective platform. @@ -120,4 +121,7 @@ class WebResourceError { /// Whether the error originated from the main frame. final bool? isForMainFrame; + + /// The URL for which the failing resource request was made. + final String? url; } diff --git a/packages/webview_flutter/webview_flutter_platform_interface/pubspec.yaml b/packages/webview_flutter/webview_flutter_platform_interface/pubspec.yaml index e5377f0fbab1..eca7b4927be3 100644 --- a/packages/webview_flutter/webview_flutter_platform_interface/pubspec.yaml +++ b/packages/webview_flutter/webview_flutter_platform_interface/pubspec.yaml @@ -4,7 +4,7 @@ repository: https://github.com/flutter/packages/tree/main/packages/webview_flutt issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview_flutter%22 # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 2.3.1 +version: 2.4.0 environment: sdk: ">=2.18.0 <4.0.0" From 66e906c75bf0ad0a26db79eb20bd689924fd28bf Mon Sep 17 00:00:00 2001 From: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> Date: Tue, 11 Jul 2023 14:42:52 -0400 Subject: [PATCH 2/2] fix name in pubspec --- .../webview_flutter_platform_interface/CHANGELOG.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md b/packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md index b56ca80b706d..30c3ab2a8d66 100644 --- a/packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md @@ -1,7 +1,6 @@ ## 2.4.0 -* Adds support to retrieve the url from a web resource loading error. See - `WebResourceError.failingUrl`. +* Adds support to retrieve the url from a web resource loading error. See `WebResourceError.url`. ## 2.3.1