From 61f143ebe82f3f0208e413b31bbf99c65a811be3 Mon Sep 17 00:00:00 2001 From: camsim99 Date: Mon, 18 Mar 2024 16:32:32 -0700 Subject: [PATCH 1/6] Change note --- packages/camera/camera_android_camerax/README.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/camera/camera_android_camerax/README.md b/packages/camera/camera_android_camerax/README.md index fdc50955de43..403be225f36d 100644 --- a/packages/camera/camera_android_camerax/README.md +++ b/packages/camera/camera_android_camerax/README.md @@ -2,10 +2,12 @@ An Android implementation of [`camera`][1] that uses the [CameraX library][2]. -*Note*: This package is under development, so please note the -[missing features and limitations](#missing-features-and-limitations), but -otherwise feel free to try out the current implementation and provide any -feedback by filing issues under [`flutter/flutter`][5] with `[camerax]` in +*Note*: Unless any of the [missing features and limitations](#missing-features-and-limitations) +may restrict you from using this implementation, please see [the instructions](#usage) +on how to use this platform implementation in place of [`camera_android`][4] as +support for it will eventually stop. Additionally, if there are any reasons you are unable to +use this package instead of `camera_android` besides those listed [below](#missing-features-and-limitations), +please report these by filing issues under [`flutter/flutter`][5] with `[camerax]` in the title, which will be actively triaged. ## Usage From 4297c92b255c2bbebe2e480793acc1a51d93ffc2 Mon Sep 17 00:00:00 2001 From: camsim99 Date: Tue, 19 Mar 2024 09:28:11 -0700 Subject: [PATCH 2/6] Rewrite --- .../camera/camera_android_camerax/README.md | 21 +++++++------------ 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/packages/camera/camera_android_camerax/README.md b/packages/camera/camera_android_camerax/README.md index 403be225f36d..f94ed855d0f4 100644 --- a/packages/camera/camera_android_camerax/README.md +++ b/packages/camera/camera_android_camerax/README.md @@ -2,13 +2,12 @@ An Android implementation of [`camera`][1] that uses the [CameraX library][2]. -*Note*: Unless any of the [missing features and limitations](#missing-features-and-limitations) -may restrict you from using this implementation, please see [the instructions](#usage) -on how to use this platform implementation in place of [`camera_android`][4] as -support for it will eventually stop. Additionally, if there are any reasons you are unable to -use this package instead of `camera_android` besides those listed [below](#missing-features-and-limitations), -please report these by filing issues under [`flutter/flutter`][5] with `[camerax]` in -the title, which will be actively triaged. +*Note*: This implementation will eventually become the default implementation +of `camera` on Android, so we strongly encourage you to opt into using it +by using [the instructions](#usage) below. If any of [the limitations](#limitations) +prevent you from using `camera_android_camerax` or if you run into any problems, +please report these issues under [`flutter/flutter`][5] with `[camerax]` in +the title. ## Usage @@ -21,10 +20,10 @@ dependency in addition to `camera`: dependencies: # ...along with your other dependencies camera: ^0.10.4 - camera_android_camerax: ^0.5.0 + camera_android_camerax: ^0.6.0 ``` -## Missing features and limitations +## Limitations ### 240p resolution configuration for video recording @@ -32,10 +31,6 @@ dependencies: and thus, the plugin will fall back to 480p if configured with a `ResolutionPreset`. -### Focus mode configuration \[[Issue #120467][120467]\] - -`setFocusMode` is unimplemented. - ### Setting maximum duration and stream options for video capture Calling `startVideoCapturing` with `VideoCaptureOptions` configured with From 93f5933c727b4e740bdebaa1cdc17424601ac326 Mon Sep 17 00:00:00 2001 From: camsim99 Date: Tue, 19 Mar 2024 09:29:54 -0700 Subject: [PATCH 3/6] Add bold --- packages/camera/camera_android_camerax/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/camera/camera_android_camerax/README.md b/packages/camera/camera_android_camerax/README.md index f94ed855d0f4..e20318e0c6ba 100644 --- a/packages/camera/camera_android_camerax/README.md +++ b/packages/camera/camera_android_camerax/README.md @@ -3,7 +3,7 @@ An Android implementation of [`camera`][1] that uses the [CameraX library][2]. *Note*: This implementation will eventually become the default implementation -of `camera` on Android, so we strongly encourage you to opt into using it +of `camera` on Android, so **we strongly encourage you to opt into it** by using [the instructions](#usage) below. If any of [the limitations](#limitations) prevent you from using `camera_android_camerax` or if you run into any problems, please report these issues under [`flutter/flutter`][5] with `[camerax]` in From b6a3ec9c78957f40b5637872827f91adcf40574c Mon Sep 17 00:00:00 2001 From: camsim99 Date: Tue, 19 Mar 2024 10:31:22 -0700 Subject: [PATCH 4/6] Add timeframe --- packages/camera/camera_android_camerax/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/camera/camera_android_camerax/README.md b/packages/camera/camera_android_camerax/README.md index e20318e0c6ba..f935f8e86528 100644 --- a/packages/camera/camera_android_camerax/README.md +++ b/packages/camera/camera_android_camerax/README.md @@ -2,8 +2,8 @@ An Android implementation of [`camera`][1] that uses the [CameraX library][2]. -*Note*: This implementation will eventually become the default implementation -of `camera` on Android, so **we strongly encourage you to opt into it** +*Note*: This implementation will become the default implementation of `camera` +on Android by May 2024, so **we strongly encourage you to opt into it** by using [the instructions](#usage) below. If any of [the limitations](#limitations) prevent you from using `camera_android_camerax` or if you run into any problems, please report these issues under [`flutter/flutter`][5] with `[camerax]` in From cb576f979b61b6362311d6419b0a7e8c065719e5 Mon Sep 17 00:00:00 2001 From: camsim99 Date: Tue, 19 Mar 2024 10:32:25 -0700 Subject: [PATCH 5/6] Bump version --- packages/camera/camera_android_camerax/CHANGELOG.md | 4 ++++ packages/camera/camera_android_camerax/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/camera/camera_android_camerax/CHANGELOG.md b/packages/camera/camera_android_camerax/CHANGELOG.md index 2fd0eb9ed3d5..9628784e6c2e 100644 --- a/packages/camera/camera_android_camerax/CHANGELOG.md +++ b/packages/camera/camera_android_camerax/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.6.1 + +* Updates `README.md` to encourage developers to opt into this implementation of the camera plugin. + ## 0.6.0 * Implements `setFocusMode`, which makes this plugin reach feature parity with camera_android. diff --git a/packages/camera/camera_android_camerax/pubspec.yaml b/packages/camera/camera_android_camerax/pubspec.yaml index a1a44f06f366..0f4756be1bb7 100644 --- a/packages/camera/camera_android_camerax/pubspec.yaml +++ b/packages/camera/camera_android_camerax/pubspec.yaml @@ -2,7 +2,7 @@ name: camera_android_camerax description: Android implementation of the camera plugin using the CameraX library. repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22 -version: 0.6.0 +version: 0.6.1 environment: sdk: ^3.1.0 From 1041abe5a684028a65b017131622d63fadd9b094 Mon Sep 17 00:00:00 2001 From: camsim99 Date: Tue, 19 Mar 2024 14:39:21 -0700 Subject: [PATCH 6/6] review --- .../camera/camera_android_camerax/CHANGELOG.md | 2 +- packages/camera/camera_android_camerax/README.md | 16 ++++++---------- .../camera/camera_android_camerax/pubspec.yaml | 2 +- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/packages/camera/camera_android_camerax/CHANGELOG.md b/packages/camera/camera_android_camerax/CHANGELOG.md index 9628784e6c2e..2226ba4352c7 100644 --- a/packages/camera/camera_android_camerax/CHANGELOG.md +++ b/packages/camera/camera_android_camerax/CHANGELOG.md @@ -1,4 +1,4 @@ -## 0.6.1 +## 0.6.0+1 * Updates `README.md` to encourage developers to opt into this implementation of the camera plugin. diff --git a/packages/camera/camera_android_camerax/README.md b/packages/camera/camera_android_camerax/README.md index f935f8e86528..64a56f1a3b54 100644 --- a/packages/camera/camera_android_camerax/README.md +++ b/packages/camera/camera_android_camerax/README.md @@ -11,18 +11,14 @@ the title. ## Usage -This package is [non-endorsed][3]; the endorsed Android implementation of `camera` -is [`camera_android`][4]. To use this implementation of the plugin instead of -`camera_android`, you will need to specify it in your `pubspec.yaml` file as a -dependency in addition to `camera`: - -```yaml -dependencies: - # ...along with your other dependencies - camera: ^0.10.4 - camera_android_camerax: ^0.6.0 +To use this plugin instead of [`camera_android`][4], run + +```sh +$ flutter pub add camera_android_camerax ``` +from your project's root directory. + ## Limitations ### 240p resolution configuration for video recording diff --git a/packages/camera/camera_android_camerax/pubspec.yaml b/packages/camera/camera_android_camerax/pubspec.yaml index 0f4756be1bb7..248da8bbd97d 100644 --- a/packages/camera/camera_android_camerax/pubspec.yaml +++ b/packages/camera/camera_android_camerax/pubspec.yaml @@ -2,7 +2,7 @@ name: camera_android_camerax description: Android implementation of the camera plugin using the CameraX library. repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22 -version: 0.6.1 +version: 0.6.0+1 environment: sdk: ^3.1.0