Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 05fc29f

Browse files
authored
Rename DeviceGestureSettings.fromWindow to DeviceGestureSettings.fromView (#119291)
1 parent 4aed487 commit 05fc29f

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

packages/flutter/lib/src/gestures/gesture_settings.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ class DeviceGestureSettings {
2424
this.touchSlop,
2525
});
2626

27-
/// Create a new [DeviceGestureSettings] from the provided [window].
28-
factory DeviceGestureSettings.fromWindow(ui.FlutterView window) {
29-
final double? physicalTouchSlop = window.viewConfiguration.gestureSettings.physicalTouchSlop;
27+
/// Create a new [DeviceGestureSettings] from the provided [view].
28+
factory DeviceGestureSettings.fromView(ui.FlutterView view) {
29+
final double? physicalTouchSlop = view.viewConfiguration.gestureSettings.physicalTouchSlop;
3030
return DeviceGestureSettings(
31-
touchSlop: physicalTouchSlop == null ? null : physicalTouchSlop / window.devicePixelRatio
31+
touchSlop: physicalTouchSlop == null ? null : physicalTouchSlop / view.devicePixelRatio
3232
);
3333
}
3434

packages/flutter/lib/src/widgets/media_query.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ class MediaQueryData {
219219
highContrast = platformData?.highContrast ?? view.platformDispatcher.accessibilityFeatures.highContrast,
220220
alwaysUse24HourFormat = platformData?.alwaysUse24HourFormat ?? view.platformDispatcher.alwaysUse24HourFormat,
221221
navigationMode = platformData?.navigationMode ?? NavigationMode.traditional,
222-
gestureSettings = DeviceGestureSettings.fromWindow(view),
222+
gestureSettings = DeviceGestureSettings.fromView(view),
223223
displayFeatures = view.displayFeatures;
224224

225225
/// The size of the media in logical pixels (e.g, the size of the screen).

packages/flutter/test/widgets/media_query_test.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ void main() {
200200
expect(data.highContrast, platformData.highContrast);
201201
expect(data.alwaysUse24HourFormat, platformData.alwaysUse24HourFormat);
202202
expect(data.navigationMode, platformData.navigationMode);
203-
expect(data.gestureSettings, DeviceGestureSettings.fromWindow(view));
203+
expect(data.gestureSettings, DeviceGestureSettings.fromView(view));
204204
expect(data.displayFeatures, view.displayFeatures);
205205
});
206206

@@ -240,7 +240,7 @@ void main() {
240240
expect(data.highContrast, platformDispatcher.accessibilityFeatures.highContrast);
241241
expect(data.alwaysUse24HourFormat, platformDispatcher.alwaysUse24HourFormat);
242242
expect(data.navigationMode, NavigationMode.traditional);
243-
expect(data.gestureSettings, DeviceGestureSettings.fromWindow(view));
243+
expect(data.gestureSettings, DeviceGestureSettings.fromView(view));
244244
expect(data.displayFeatures, view.displayFeatures);
245245
});
246246

@@ -296,7 +296,7 @@ void main() {
296296
expect(data.highContrast, platformData.highContrast);
297297
expect(data.alwaysUse24HourFormat, platformData.alwaysUse24HourFormat);
298298
expect(data.navigationMode, platformData.navigationMode);
299-
expect(data.gestureSettings, DeviceGestureSettings.fromWindow(view));
299+
expect(data.gestureSettings, DeviceGestureSettings.fromView(view));
300300
expect(data.displayFeatures, view.displayFeatures);
301301
});
302302

@@ -354,7 +354,7 @@ void main() {
354354
expect(data.highContrast, platformDispatcher.accessibilityFeatures.highContrast);
355355
expect(data.alwaysUse24HourFormat, platformDispatcher.alwaysUse24HourFormat);
356356
expect(data.navigationMode, NavigationMode.traditional);
357-
expect(data.gestureSettings, DeviceGestureSettings.fromWindow(view));
357+
expect(data.gestureSettings, DeviceGestureSettings.fromView(view));
358358
expect(data.displayFeatures, view.displayFeatures);
359359
});
360360

0 commit comments

Comments
 (0)