Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 0609adb

Browse files
[tools] Recognize Pigeon tests in version-check (#6813)
Pigeon has an usual test structure since it generates test code to run in a dummy plugin; add that structure to the list of recognized tests so that changes to its platform tests won't be flagged by `version-check`.
1 parent 2dab59d commit 0609adb

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

script/tool/CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
## NEXT
1+
## 13.1
22

3+
* Updates `version-check` to recognize Pigeon's platform test structure.
34
* Pins `package:git` dependency to `2.0.x` until `dart >=2.18.0` becomes our
45
oldest legacy.
56
* Updates test mocks.

script/tool/lib/src/common/package_state_utils.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,9 @@ bool _isTestChange(List<String> pathComponents) {
110110
pathComponents.contains('integration_test') ||
111111
pathComponents.contains('androidTest') ||
112112
pathComponents.contains('RunnerTests') ||
113-
pathComponents.contains('RunnerUITests');
113+
pathComponents.contains('RunnerUITests') ||
114+
// Pigeon's custom platform tests.
115+
pathComponents.first == 'platform_tests';
114116
}
115117

116118
// True if the given file is an example file other than the one that will be

script/tool/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: flutter_plugin_tools
22
description: Productivity utils for flutter/plugins and flutter/packages
33
repository: https://github.com/flutter/plugins/tree/main/script/tool
4-
version: 0.13.0
4+
version: 0.13.1
55

66
dependencies:
77
args: ^2.1.0

script/tool/test/common/package_state_utils_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@ void main() {
8080
'packages/a_plugin/example/macos/Runner.xcodeproj/project.pbxproj',
8181
'packages/a_plugin/example/windows/CMakeLists.txt',
8282
'packages/a_plugin/example/pubspec.yaml',
83+
// Pigeon platform tests, which have an unusual structure.
84+
'packages/a_plugin/platform_tests/shared_test_plugin_code/lib/integration_tests.dart',
85+
'packages/a_plugin/platform_tests/test_plugin/windows/test_plugin.cpp',
8386
];
8487

8588
final PackageChangeState state = await checkPackageChangeState(package,

0 commit comments

Comments
 (0)