Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 64a2931

Browse files
authored
[google_sign_in_android] Corrects typo in logs (#6216)
1 parent 993170f commit 64a2931

File tree

3 files changed

+9
-12
lines changed

3 files changed

+9
-12
lines changed

packages/google_sign_in/google_sign_in_android/CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
## NEXT
1+
## 6.1.1
22

3+
* Corrects typos in plugin error logs and removes not actionable warnings.
34
* Updates minimum Flutter version to 2.10.
45

56
## 6.1.0

packages/google_sign_in/google_sign_in_android/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -356,16 +356,12 @@ public void init(
356356
// Android apps are identified by their package name and the SHA-1 of their signing key.
357357
// https://developers.google.com/android/guides/client-auth
358358
// https://developers.google.com/identity/sign-in/android/start#configure-a-google-api-project
359-
if (!Strings.isNullOrEmpty(clientId)) {
360-
if (Strings.isNullOrEmpty(serverClientId)) {
361-
Log.w(
362-
"google_sing_in",
363-
"clientId is not supported on Android and is interpreted as serverClientId."
364-
+ "Use serverClientId instead to suppress this warning.");
365-
serverClientId = clientId;
366-
} else {
367-
Log.w("google_sing_in", "clientId is not supported on Android and is ignored.");
368-
}
359+
if (!Strings.isNullOrEmpty(clientId) && Strings.isNullOrEmpty(serverClientId)) {
360+
Log.w(
361+
"google_sign_in",
362+
"clientId is not supported on Android and is interpreted as serverClientId. "
363+
+ "Use serverClientId instead to suppress this warning.");
364+
serverClientId = clientId;
369365
}
370366

371367
if (Strings.isNullOrEmpty(serverClientId)) {

packages/google_sign_in/google_sign_in_android/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: google_sign_in_android
22
description: Android implementation of the google_sign_in plugin.
33
repository: https://github.com/flutter/plugins/tree/main/packages/google_sign_in/google_sign_in_android
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_sign_in%22
5-
version: 6.1.0
5+
version: 6.1.1
66

77
environment:
88
sdk: ">=2.14.0 <3.0.0"

0 commit comments

Comments
 (0)