fix test

update changelog

add debug info

revert

also check for old accessiblity value

Author: Chris Yang

packages/video_player/video_player_avfoundation/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 2.3.3
+
+* Fix XCUITest based on the new voice over announcement for tooltips.
+  See: https://github.com/flutter/flutter/pull/87684
+
 ## 2.3.2
 
 * Applies the standardized transform for videos with different orientations.

packages/video_player/video_player_avfoundation/example/ios/RunnerUITests/VideoPlayerUITests.m

@@ -30,16 +30,35 @@ - (void)testPlayVideo {
   XCTAssertTrue([playButton waitForExistenceWithTimeout:30.0]);
   [playButton tap];
 
-  XCUIElement *playbackSpeed1x = app.staticTexts[@"Playback speed\n1.0x"];
-  XCTAssertTrue([playbackSpeed1x waitForExistenceWithTimeout:30.0]);
+  XCUIElement *playbackSpeed1x = app.staticTexts[@"1.0x\nPlayback speed"];
+  BOOL foundPlaybackSpeed1x = [playbackSpeed1x waitForExistenceWithTimeout:30.0];
+  if (!foundPlaybackSpeed1x) {
+    // Some old flutter version uses a different accessibility value for tooltips.
+    // We try to find the button if the old accessibility value is used.
+    // TODO(cyanglaz): Remove this when the new accessibility value is supported on flutter/stable
+    // https://github.com/flutter/flutter/issues/102771
+    playbackSpeed1x = app.staticTexts[@"Playback speed\n1.0x\n"];
+    foundPlaybackSpeed1x = [playbackSpeed1x waitForExistenceWithTimeout:30.0];
+  }
+  XCTAssertTrue(foundPlaybackSpeed1x);
   [playbackSpeed1x tap];
 
   XCUIElement *playbackSpeed5xButton = app.buttons[@"5.0x"];
   XCTAssertTrue([playbackSpeed5xButton waitForExistenceWithTimeout:30.0]);
   [playbackSpeed5xButton tap];
 
-  XCUIElement *playbackSpeed5x = app.staticTexts[@"Playback speed\n5.0x"];
-  XCTAssertTrue([playbackSpeed5x waitForExistenceWithTimeout:30.0]);
+  XCUIElement *playbackSpeed5x = app.staticTexts[@"5.0x\nPlayback speed"];
+  BOOL foundPlaybackSpeed5x = [playbackSpeed5x waitForExistenceWithTimeout:30.0];
+  if (!foundPlaybackSpeed5x) {
+    // Some old flutter version uses a different accessibility value for tooltips.
+    // We try to find the button if the old accessibility value is used.
+    // TODO(cyanglaz): Remove this when the new accessibility value is supported on flutter/stable
+    // https://github.com/flutter/flutter/issues/102771
+    playbackSpeed5x = app.staticTexts[@"Playback speed\n5.0x\n"];
+    foundPlaybackSpeed5x = [playbackSpeed5x waitForExistenceWithTimeout:30.0];
+  }
+  XCTAssertTrue(foundPlaybackSpeed5x);
+  [playbackSpeed5x tap];
 
   // Cycle through tabs.
   for (NSString *tabName in @[ @"Asset", @"Remote" ]) {

packages/video_player/video_player_avfoundation/pubspec.yaml

@@ -2,7 +2,7 @@ name: video_player_avfoundation
 description: iOS implementation of the video_player plugin.
 repository: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player_avfoundation
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
-version: 2.3.2
+version: 2.3.3
 
 environment:
   sdk: ">=2.14.0 <3.0.0"