Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 782a7a9

Browse files
PiinksPiinks
authored
[video_player] Migrate deprecated api (#3409)
1 parent a0e7937 commit 782a7a9

File tree

4 files changed

+58
-77
lines changed

4 files changed

+58
-77
lines changed

‎packages/video_player/video_player/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.0.0-nullsafety.8
2+
3+
* Migrated from deprecated `defaultBinaryMessenger`.
4+
15
## 2.0.0-nullsafety.7
26

37
* Update the example app: remove the deprecated `RaisedButton` and `FlatButton` widgets.

‎packages/video_player/video_player/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: Flutter plugin for displaying inline video with other Flutter
44
# 0.10.y+z is compatible with 1.0.0, if you land a breaking change bump
55
# the version to 2.0.0.
66
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
7-
version: 2.0.0-nullsafety.7
7+
version: 2.0.0-nullsafety.8
88
homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player
99

1010
flutter:

‎packages/video_player/video_player/test/video_player_test.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -795,11 +795,7 @@ class FakeEventsChannel {
795795
}
796796

797797
void _sendMessage(ByteData data) {
798-
// TODO(jackson): This has been deprecated and should be replaced
799-
// with `ServicesBinding.instance.defaultBinaryMessenger` when it's
800-
// available on all the versions of Flutter that we test.
801-
// ignore: deprecated_member_use
802-
defaultBinaryMessenger.handlePlatformMessage(
798+
ServicesBinding.instance!.defaultBinaryMessenger.handlePlatformMessage(
803799
eventsMethodChannel.name, data, (ByteData? data) {});
804800
}
805801
}

‎packages/video_player/video_player_platform_interface/test/method_channel_video_player_test.dart

Lines changed: 52 additions & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -234,82 +234,63 @@ void main() {
234234
});
235235

236236
test('videoEventsFor', () async {
237-
// TODO(cbenhagen): This has been deprecated and should be replaced
238-
// with `ServicesBinding.instance.defaultBinaryMessenger` when it's
239-
// available on all the versions of Flutter that we test.
240-
// ignore: deprecated_member_use
241-
defaultBinaryMessenger.setMockMessageHandler(
237+
ServicesBinding.instance.defaultBinaryMessenger.setMockMessageHandler(
242238
"flutter.io/videoPlayer/videoEvents123",
243239
(ByteData message) async {
244240
final MethodCall methodCall =
245241
const StandardMethodCodec().decodeMethodCall(message);
246242
if (methodCall.method == 'listen') {
247-
// TODO(cbenhagen): This has been deprecated and should be replaced
248-
// with `ServicesBinding.instance.defaultBinaryMessenger` when it's
249-
// available on all the versions of Flutter that we test.
250-
// ignore: deprecated_member_use
251-
await defaultBinaryMessenger.handlePlatformMessage(
252-
"flutter.io/videoPlayer/videoEvents123",
253-
const StandardMethodCodec()
254-
.encodeSuccessEnvelope(<String, dynamic>{
255-
'event': 'initialized',
256-
'duration': 98765,
257-
'width': 1920,
258-
'height': 1080,
259-
}),
260-
(ByteData data) {});
261-
262-
// TODO(cbenhagen): This has been deprecated and should be replaced
263-
// with `ServicesBinding.instance.defaultBinaryMessenger` when it's
264-
// available on all the versions of Flutter that we test.
265-
// ignore: deprecated_member_use
266-
await defaultBinaryMessenger.handlePlatformMessage(
267-
"flutter.io/videoPlayer/videoEvents123",
268-
const StandardMethodCodec()
269-
.encodeSuccessEnvelope(<String, dynamic>{
270-
'event': 'completed',
271-
}),
272-
(ByteData data) {});
273-
274-
// TODO(cbenhagen): This has been deprecated and should be replaced
275-
// with `ServicesBinding.instance.defaultBinaryMessenger` when it's
276-
// available on all the versions of Flutter that we test.
277-
// ignore: deprecated_member_use
278-
await defaultBinaryMessenger.handlePlatformMessage(
279-
"flutter.io/videoPlayer/videoEvents123",
280-
const StandardMethodCodec()
281-
.encodeSuccessEnvelope(<String, dynamic>{
282-
'event': 'bufferingUpdate',
283-
'values': <List<dynamic>>[
284-
<int>[0, 1234],
285-
<int>[1235, 4000],
286-
],
287-
}),
288-
(ByteData data) {});
289-
290-
// TODO(cbenhagen): This has been deprecated and should be replaced
291-
// with `ServicesBinding.instance.defaultBinaryMessenger` when it's
292-
// available on all the versions of Flutter that we test.
293-
// ignore: deprecated_member_use
294-
await defaultBinaryMessenger.handlePlatformMessage(
295-
"flutter.io/videoPlayer/videoEvents123",
296-
const StandardMethodCodec()
297-
.encodeSuccessEnvelope(<String, dynamic>{
298-
'event': 'bufferingStart',
299-
}),
300-
(ByteData data) {});
301-
302-
// TODO(cbenhagen): This has been deprecated and should be replaced
303-
// with `ServicesBinding.instance.defaultBinaryMessenger` when it's
304-
// available on all the versions of Flutter that we test.
305-
// ignore: deprecated_member_use
306-
await defaultBinaryMessenger.handlePlatformMessage(
307-
"flutter.io/videoPlayer/videoEvents123",
308-
const StandardMethodCodec()
309-
.encodeSuccessEnvelope(<String, dynamic>{
310-
'event': 'bufferingEnd',
311-
}),
312-
(ByteData data) {});
243+
await ServicesBinding.instance.defaultBinaryMessenger
244+
.handlePlatformMessage(
245+
"flutter.io/videoPlayer/videoEvents123",
246+
const StandardMethodCodec()
247+
.encodeSuccessEnvelope(<String, dynamic>{
248+
'event': 'initialized',
249+
'duration': 98765,
250+
'width': 1920,
251+
'height': 1080,
252+
}),
253+
(ByteData data) {});
254+
255+
await ServicesBinding.instance.defaultBinaryMessenger
256+
.handlePlatformMessage(
257+
"flutter.io/videoPlayer/videoEvents123",
258+
const StandardMethodCodec()
259+
.encodeSuccessEnvelope(<String, dynamic>{
260+
'event': 'completed',
261+
}),
262+
(ByteData data) {});
263+
264+
await ServicesBinding.instance.defaultBinaryMessenger
265+
.handlePlatformMessage(
266+
"flutter.io/videoPlayer/videoEvents123",
267+
const StandardMethodCodec()
268+
.encodeSuccessEnvelope(<String, dynamic>{
269+
'event': 'bufferingUpdate',
270+
'values': <List<dynamic>>[
271+
<int>[0, 1234],
272+
<int>[1235, 4000],
273+
],
274+
}),
275+
(ByteData data) {});
276+
277+
await ServicesBinding.instance.defaultBinaryMessenger
278+
.handlePlatformMessage(
279+
"flutter.io/videoPlayer/videoEvents123",
280+
const StandardMethodCodec()
281+
.encodeSuccessEnvelope(<String, dynamic>{
282+
'event': 'bufferingStart',
283+
}),
284+
(ByteData data) {});
285+
286+
await ServicesBinding.instance.defaultBinaryMessenger
287+
.handlePlatformMessage(
288+
"flutter.io/videoPlayer/videoEvents123",
289+
const StandardMethodCodec()
290+
.encodeSuccessEnvelope(<String, dynamic>{
291+
'event': 'bufferingEnd',
292+
}),
293+
(ByteData data) {});
313294

314295
return const StandardMethodCodec().encodeSuccessEnvelope(null);
315296
} else if (methodCall.method == 'cancel') {

0 commit comments

Comments
 (0)