[firebase_performance] Fix invokeMethod formatting that caused a bug with Dart code obfuscation (#1874)

* Fix invokeMethod formatting that caused a bug with Dart code obfuscation

Author: axel-op

packages/firebase_performance/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.0+3
+
+* Fix bug that caused `invokeMethod` to fail with Dart code obfuscation
+
 ## 0.3.0+2
 
 * Fix bug preventing this plugin from working with hot restart.

packages/firebase_performance/lib/src/firebase_performance.dart

@@ -37,7 +37,7 @@ class FirebasePerformance {
   /// does not reflect whether instrumentation is enabled/disabled.
   Future<bool> isPerformanceCollectionEnabled() {
     return channel.invokeMethod<bool>(
-      '$FirebasePerformance#isPerformanceCollectionEnabled',
+      'FirebasePerformance#isPerformanceCollectionEnabled',
       <String, dynamic>{'handle': _handle},
     );
   }
@@ -48,7 +48,7 @@ class FirebasePerformance {
   /// application. By default, performance monitoring is enabled.
   Future<void> setPerformanceCollectionEnabled(bool enable) {
     return channel.invokeMethod<void>(
-      '$FirebasePerformance#setPerformanceCollectionEnabled',
+      'FirebasePerformance#setPerformanceCollectionEnabled',
       <String, dynamic>{'handle': _handle, 'enable': enable},
     );
   }
@@ -62,7 +62,7 @@ class FirebasePerformance {
     final int handle = _nextHandle++;
 
     FirebasePerformance.channel.invokeMethod<void>(
-      '$FirebasePerformance#newTrace',
+      'FirebasePerformance#newTrace',
       <String, dynamic>{'handle': _handle, 'traceHandle': handle, 'name': name},
     );
 
@@ -74,7 +74,7 @@ class FirebasePerformance {
     final int handle = _nextHandle++;
 
     FirebasePerformance.channel.invokeMethod<void>(
-      '$FirebasePerformance#newHttpMetric',
+      'FirebasePerformance#newHttpMetric',
       <String, dynamic>{
         'handle': _handle,
         'httpMetricHandle': handle,

packages/firebase_performance/lib/src/http_metric.dart

@@ -59,7 +59,7 @@ class HttpMetric extends PerformanceAttributes {
 
     _httpResponseCode = httpResponseCode;
     FirebasePerformance.channel.invokeMethod<void>(
-      '$HttpMetric#httpResponseCode',
+      'HttpMetric#httpResponseCode',
       <String, dynamic>{
         'handle': _handle,
         'httpResponseCode': httpResponseCode,
@@ -76,7 +76,7 @@ class HttpMetric extends PerformanceAttributes {
 
     _requestPayloadSize = requestPayloadSize;
     FirebasePerformance.channel.invokeMethod<void>(
-      '$HttpMetric#requestPayloadSize',
+      'HttpMetric#requestPayloadSize',
       <String, dynamic>{
         'handle': _handle,
         'requestPayloadSize': requestPayloadSize,
@@ -93,7 +93,7 @@ class HttpMetric extends PerformanceAttributes {
 
     _responseContentType = responseContentType;
     FirebasePerformance.channel.invokeMethod<void>(
-      '$HttpMetric#responseContentType',
+      'HttpMetric#responseContentType',
       <String, dynamic>{
         'handle': _handle,
         'responseContentType': responseContentType,
@@ -110,7 +110,7 @@ class HttpMetric extends PerformanceAttributes {
 
     _responsePayloadSize = responsePayloadSize;
     FirebasePerformance.channel.invokeMethod<void>(
-      '$HttpMetric#responsePayloadSize',
+      'HttpMetric#responsePayloadSize',
       <String, dynamic>{
         'handle': _handle,
         'responsePayloadSize': responsePayloadSize,
@@ -129,7 +129,7 @@ class HttpMetric extends PerformanceAttributes {
 
     _hasStarted = true;
     return FirebasePerformance.channel.invokeMethod<void>(
-      '$HttpMetric#start',
+      'HttpMetric#start',
       <String, dynamic>{'handle': _handle},
     );
   }
@@ -147,7 +147,7 @@ class HttpMetric extends PerformanceAttributes {
 
     _hasStopped = true;
     return FirebasePerformance.channel.invokeMethod<void>(
-      '$HttpMetric#stop',
+      'HttpMetric#stop',
       <String, dynamic>{'handle': _handle},
     );
   }

packages/firebase_performance/lib/src/performance_attributes.dart

@@ -48,7 +48,7 @@ abstract class PerformanceAttributes {
 
     _attributes[name] = value;
     return FirebasePerformance.channel.invokeMethod<void>(
-      '$PerformanceAttributes#putAttribute',
+      'PerformanceAttributes#putAttribute',
       <String, dynamic>{
         'handle': _handle,
         'name': name,
@@ -66,7 +66,7 @@ abstract class PerformanceAttributes {
 
     _attributes.remove(name);
     return FirebasePerformance.channel.invokeMethod<void>(
-      '$PerformanceAttributes#removeAttribute',
+      'PerformanceAttributes#removeAttribute',
       <String, dynamic>{'handle': _handle, 'name': name},
     );
   }
@@ -85,7 +85,7 @@ abstract class PerformanceAttributes {
     }
 
     return FirebasePerformance.channel.invokeMapMethod<String, String>(
-      '$PerformanceAttributes#getAttributes',
+      'PerformanceAttributes#getAttributes',
       <String, dynamic>{'handle': _handle},
     );
   }

packages/firebase_performance/lib/src/trace.dart

@@ -52,7 +52,7 @@ class Trace extends PerformanceAttributes {
 
     _hasStarted = true;
     return FirebasePerformance.channel.invokeMethod<void>(
-      '$Trace#start',
+      'Trace#start',
       <String, dynamic>{'handle': _handle},
     );
   }
@@ -70,7 +70,7 @@ class Trace extends PerformanceAttributes {
 
     _hasStopped = true;
     return FirebasePerformance.channel.invokeMethod<void>(
-      '$Trace#stop',
+      'Trace#stop',
       <String, dynamic>{'handle': _handle},
     );
   }
@@ -88,7 +88,7 @@ class Trace extends PerformanceAttributes {
     _metrics.putIfAbsent(name, () => 0);
     _metrics[name] += value;
     return FirebasePerformance.channel.invokeMethod<void>(
-      '$Trace#incrementMetric',
+      'Trace#incrementMetric',
       <String, dynamic>{'handle': _handle, 'name': name, 'value': value},
     );
   }
@@ -103,7 +103,7 @@ class Trace extends PerformanceAttributes {
 
     _metrics[name] = value;
     return FirebasePerformance.channel.invokeMethod<void>(
-      '$Trace#setMetric',
+      'Trace#setMetric',
       <String, dynamic>{'handle': _handle, 'name': name, 'value': value},
     );
   }
@@ -116,7 +116,7 @@ class Trace extends PerformanceAttributes {
     if (_hasStopped) return Future<int>.value(_metrics[name] ?? 0);
 
     return FirebasePerformance.channel.invokeMethod<int>(
-      '$Trace#getMetric',
+      'Trace#getMetric',
       <String, dynamic>{'handle': _handle, 'name': name},
     );
   }

packages/firebase_performance/pubspec.yaml

@@ -4,7 +4,7 @@ description: Flutter plugin for Google Performance Monitoring for Firebase, an a
   iOS.
 author: Flutter Team <[email protected]>
 homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_performance
-version: 0.3.0+2
+version: 0.3.0+3
 
 dependencies:
   flutter: