Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 9c12e31

Browse files
committed
apply feedback
1 parent 29c86f1 commit 9c12e31

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

packages/file_selector/file_selector_platform_interface/CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## 2.3.0
22

3-
* Adds the `uniformTypeIdentifiers` property to the `XTypeGroup` that relies on `macUTIs`. The last will be deprecated for future releases.
3+
* Replaces `macUTIs` with `uniformTypeIdentifiers`. `macUTIs` is available as an alias, but will be deprecated in a future release.
44

55
## 2.2.0
66

packages/file_selector/file_selector_platform_interface/lib/src/types/x_type_group/x_type_group.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class XTypeGroup {
1919
this.webWildCards,
2020
}) : _extensions = extensions,
2121
assert(uniformTypeIdentifiers == null || macUTIs == null,
22-
'It is only allowed to specify either macUTIs or uniformTypeIdentifiers'),
22+
'Only one of uniformTypeIdentifiers or macUTIs can be non-null'),
2323
uniformTypeIdentifiers = uniformTypeIdentifiers ?? macUTIs;
2424

2525
/// The 'name' or reference to this group of types.

packages/file_selector/file_selector_platform_interface/test/x_type_group_test.dart

+4-2
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,9 @@ void main() {
9999
expect(group.macUTIs, macUTIs);
100100
});
101101

102-
test('macUTIs getter returns uniformTypeIdentifiers value passed in constructor', () {
102+
test(
103+
'macUTIs getter returns uniformTypeIdentifiers value passed in constructor',
104+
() {
103105
const List<String> uniformTypeIdentifiers = <String>['public.plain-text'];
104106
const XTypeGroup group = XTypeGroup(
105107
uniformTypeIdentifiers: uniformTypeIdentifiers,
@@ -120,7 +122,7 @@ void main() {
120122
throwsA(predicate((Object? e) =>
121123
e is AssertionError &&
122124
e.message ==
123-
'It is only allowed to specify either macUTIs or uniformTypeIdentifiers')));
125+
'Only one of uniformTypeIdentifiers or macUTIs can be non-null')));
124126
});
125127

126128
test(

0 commit comments

Comments
 (0)