Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit bc16b95

Browse files
committed
upgraded usage of BinaryMessenger
1 parent c85fa03 commit bc16b95

File tree

4 files changed

+27
-12
lines changed

4 files changed

+27
-12
lines changed

packages/android_intent/android/src/test/java/io/flutter/plugins/androidintent/MethodCallHandlerImplTest.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public void startListening_registersChannel() {
5555
methodCallHandler.startListening(messenger);
5656

5757
verify(messenger, times(1))
58-
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class));
58+
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class), eq(null));
5959
}
6060

6161
@Test
@@ -67,9 +67,9 @@ public void startListening_unregistersExistingChannel() {
6767
methodCallHandler.startListening(secondMessenger);
6868

6969
// Unregisters the first and then registers the second.
70-
verify(firstMessenger, times(1)).setMessageHandler(CHANNEL_NAME, null);
70+
verify(firstMessenger, times(1)).setMessageHandler(CHANNEL_NAME, null, null);
7171
verify(secondMessenger, times(1))
72-
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class));
72+
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class), eq(null));
7373
}
7474

7575
@Test
@@ -79,7 +79,7 @@ public void stopListening_unregistersExistingChannel() {
7979

8080
methodCallHandler.stopListening();
8181

82-
verify(messenger, times(1)).setMessageHandler(CHANNEL_NAME, null);
82+
verify(messenger, times(1)).setMessageHandler(CHANNEL_NAME, null, null);
8383
}
8484

8585
@Test
@@ -88,7 +88,7 @@ public void stopListening_doesNothingWhenUnset() {
8888

8989
methodCallHandler.stopListening();
9090

91-
verify(messenger, never()).setMessageHandler(CHANNEL_NAME, null);
91+
verify(messenger, never()).setMessageHandler(CHANNEL_NAME, null, null);
9292
}
9393

9494
@Test

packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/DartMessengerTest.java

+8-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
import android.os.Handler;
1414
import androidx.annotation.NonNull;
15+
import androidx.annotation.Nullable;
1516
import io.flutter.embedding.engine.systemchannels.PlatformChannel;
1617
import io.flutter.plugin.common.BinaryMessenger;
1718
import io.flutter.plugin.common.MethodCall;
@@ -31,6 +32,11 @@ public class DartMessengerTest {
3132
private static class FakeBinaryMessenger implements BinaryMessenger {
3233
private final List<ByteBuffer> sentMessages = new ArrayList<>();
3334

35+
@Override
36+
TaskQueue makeBackgroundTaskQueue() {
37+
return null;
38+
}
39+
3440
@Override
3541
public void send(@NonNull String channel, ByteBuffer message) {
3642
sentMessages.add(message);
@@ -42,7 +48,8 @@ public void send(@NonNull String channel, ByteBuffer message, BinaryReply callba
4248
}
4349

4450
@Override
45-
public void setMessageHandler(@NonNull String channel, BinaryMessageHandler handler) {}
51+
public void setMessageHandler(
52+
@NonNull String channel, BinaryMessageHandler handler, @Nullable TaskQueue taskQueue) {}
4653

4754
List<ByteBuffer> getMessages() {
4855
return new ArrayList<>(sentMessages);

packages/quick_actions/quick_actions/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java

+9-1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@ public class QuickActionsTest {
3333
private static class TestBinaryMessenger implements BinaryMessenger {
3434
public MethodCall lastMethodCall;
3535

36+
@Override
37+
TaskQueue makeBackgroundTaskQueue() {
38+
return null;
39+
}
40+
3641
@Override
3742
public void send(@NonNull String channel, @Nullable ByteBuffer message) {
3843
send(channel, message, null);
@@ -50,7 +55,10 @@ public void send(
5055
}
5156

5257
@Override
53-
public void setMessageHandler(@NonNull String channel, @Nullable BinaryMessageHandler handler) {
58+
public void setMessageHandler(
59+
@NonNull String channel,
60+
@Nullable BinaryMessageHandler handler,
61+
@Nullable TaskQueue taskQueue) {
5462
// Do nothing.
5563
}
5664
}

packages/url_launcher/url_launcher/android/src/test/java/io/flutter/plugins/urllauncher/MethodCallHandlerImplTest.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public void startListening_registersChannel() {
4444
methodCallHandler.startListening(messenger);
4545

4646
verify(messenger, times(1))
47-
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class));
47+
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class), eq(null));
4848
}
4949

5050
@Test
@@ -56,9 +56,9 @@ public void startListening_unregistersExistingChannel() {
5656
methodCallHandler.startListening(secondMessenger);
5757

5858
// Unregisters the first and then registers the second.
59-
verify(firstMessenger, times(1)).setMessageHandler(CHANNEL_NAME, null);
59+
verify(firstMessenger, times(1)).setMessageHandler(CHANNEL_NAME, null, null);
6060
verify(secondMessenger, times(1))
61-
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class));
61+
.setMessageHandler(eq(CHANNEL_NAME), any(BinaryMessageHandler.class), eq(null));
6262
}
6363

6464
@Test
@@ -68,7 +68,7 @@ public void stopListening_unregistersExistingChannel() {
6868

6969
methodCallHandler.stopListening();
7070

71-
verify(messenger, times(1)).setMessageHandler(CHANNEL_NAME, null);
71+
verify(messenger, times(1)).setMessageHandler(CHANNEL_NAME, null, null);
7272
}
7373

7474
@Test
@@ -77,7 +77,7 @@ public void stopListening_doesNothingWhenUnset() {
7777

7878
methodCallHandler.stopListening();
7979

80-
verify(messenger, never()).setMessageHandler(CHANNEL_NAME, null);
80+
verify(messenger, never()).setMessageHandler(CHANNEL_NAME, null, null);
8181
}
8282

8383
@Test

0 commit comments

Comments
 (0)