Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit c06313d

Browse files
committed
Improve expectation in unit test
1 parent eaab52e commit c06313d

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

packages/webview_flutter/webview_flutter_android/test/webview_android_widget_test.dart

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -888,8 +888,7 @@ void main() {
888888
});
889889

890890
webViewClient.urlLoading(MockWebView(), 'https://flutter.dev');
891-
await completer.future;
892-
expect(completer.isCompleted, isTrue);
891+
expect(completer.future, completes);
893892
});
894893

895894
test(
@@ -983,12 +982,11 @@ void main() {
983982
});
984983

985984
webViewClient.requestLoading(MockWebView(), mockRequest);
986-
await completer.future;
987-
expect(completer.isCompleted, isTrue);
985+
expect(completer.future, completes);
988986
});
989987

990988
test(
991-
'requestLoading should not call onLoadUrlCallback when onNavigationRequestCallback returns false',
989+
'requestLoading should not call loadUrl when onNavigationRequestCallback returns false',
992990
() {
993991
final MockWebResourceRequest mockRequest = MockWebResourceRequest();
994992
when(mockRequest.isForMainFrame).thenReturn(true);
@@ -1012,7 +1010,7 @@ void main() {
10121010
});
10131011

10141012
test(
1015-
'requestLoading should not call onLoadUrlCallback when onNavigationRequestCallback returns a Future false',
1013+
'requestLoading should not call loadUrl when onNavigationRequestCallback returns a Future false',
10161014
() {
10171015
final MockWebResourceRequest mockRequest = MockWebResourceRequest();
10181016
when(mockRequest.isForMainFrame).thenReturn(true);

0 commit comments

Comments
 (0)