Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit d8fffef

Browse files
CareFCareF
committed
formatting
1 parent 1b60d2f commit d8fffef

File tree

4 files changed

+49
-43
lines changed

4 files changed

+49
-43
lines changed

‎packages/e2e/lib/e2e_driver.dart

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ Future<void> main() => e2eDriver();
1919
/// Tests should write any output files to this directory. Defaults to the path
2020
/// set in the FLUTTER_TEST_OUTPUTS_DIR environment variable, or `build` if
2121
/// unset.
22-
String testOutputsDirectory = Platform.environment['FLUTTER_TEST_OUTPUTS_DIR'] ?? 'build';
22+
String testOutputsDirectory =
23+
Platform.environment['FLUTTER_TEST_OUTPUTS_DIR'] ?? 'build';
2324

2425
/// The callback type to handle [e2e.Response.data] after the test succcess.
2526
typedef ResponseDataCallback = FutureOr<void> Function(Map<String, dynamic>);
@@ -28,14 +29,15 @@ typedef ResponseDataCallback = FutureOr<void> Function(Map<String, dynamic>);
2829
/// [testOutputsDirectory]/`testOutputFilename.json`.
2930
///
3031
/// This is the default `responseDataCallback` in [e2eDriver].
31-
Future<void> writeResponseData(Map<String, dynamic> data, {
32+
Future<void> writeResponseData(
33+
Map<String, dynamic> data, {
3234
String testOutputFilename = 'e2e_perf_summary',
3335
}) async {
3436
assert(testOutputFilename != null);
3537
await fs.directory(testOutputsDirectory).create(recursive: true);
3638
final File file = fs.file(path.join(
3739
testOutputsDirectory,
38-
'$testOutputFilename.json'
40+
'$testOutputFilename.json',
3941
));
4042
final String resultString = _encodeJson(data, true);
4143
await file.writeAsString(resultString);
@@ -66,8 +68,7 @@ Future<void> e2eDriver({
6668
ResponseDataCallback responseDataCallback = writeResponseData,
6769
}) async {
6870
final FlutterDriver driver = await FlutterDriver.connect();
69-
final String jsonResult =
70-
await driver.requestData(null, timeout: timeout);
71+
final String jsonResult = await driver.requestData(null, timeout: timeout);
7172
final e2e.Response response = e2e.Response.fromJson(jsonResult);
7273
await driver.close();
7374

@@ -84,7 +85,5 @@ Future<void> e2eDriver({
8485
const JsonEncoder _prettyEncoder = JsonEncoder.withIndent(' ');
8586

8687
String _encodeJson(Map<String, dynamic> jsonObject, bool pretty) {
87-
return pretty
88-
? _prettyEncoder.convert(jsonObject)
89-
: json.encode(jsonObject);
88+
return pretty ? _prettyEncoder.convert(jsonObject) : json.encode(jsonObject);
9089
}

‎packages/e2e/lib/e2e_perf.dart

Lines changed: 39 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,15 @@ class FrameTimingSummarizer {
5858
final List<Duration> frameBuildTime = List<Duration>.unmodifiable(
5959
data.map<Duration>((FrameTiming datum) => datum.buildDuration),
6060
);
61-
final List<Duration> frameBuildTimeSorted = List<Duration>.from(frameBuildTime)..sort();
61+
final List<Duration> frameBuildTimeSorted =
62+
List<Duration>.from(frameBuildTime)..sort();
6263
final List<Duration> frameRasterizerTime = List<Duration>.unmodifiable(
6364
data.map<Duration>((FrameTiming datum) => datum.rasterDuration),
6465
);
65-
final List<Duration> frameRasterizerTimeSorted = List<Duration>.from(frameRasterizerTime)..sort();
66-
final Duration Function(Duration, Duration) add = (Duration a, Duration b) => a + b;
66+
final List<Duration> frameRasterizerTimeSorted =
67+
List<Duration>.from(frameRasterizerTime)..sort();
68+
final Duration Function(Duration, Duration) add =
69+
(Duration a, Duration b) => a + b;
6770
return FrameTimingSummarizer._(
6871
frameBuildTime: frameBuildTime,
6972
frameRasterizerTime: frameRasterizerTime,
@@ -74,11 +77,13 @@ class FrameTimingSummarizer {
7477
p99FrameBuildTime: _findPercentile(frameBuildTimeSorted, 0.99),
7578
worstFrameBuildTime: frameBuildTimeSorted.last,
7679
missedFrameBuildBudget: _countExceed(frameBuildTimeSorted, kBuildBudget),
77-
averageFrameRasterizerTime: frameRasterizerTime.reduce(add) ~/ data.length,
80+
averageFrameRasterizerTime:
81+
frameRasterizerTime.reduce(add) ~/ data.length,
7882
p90FrameRasterizerTime: _findPercentile(frameRasterizerTimeSorted, 0.90),
7983
p99FrameRasterizerTime: _findPercentile(frameRasterizerTimeSorted, 0.99),
8084
worstFrameRasterizerTime: frameRasterizerTimeSorted.last,
81-
missedFrameRasterizerBudget: _countExceed(frameRasterizerTimeSorted, kBuildBudget),
85+
missedFrameRasterizerBudget:
86+
_countExceed(frameRasterizerTimeSorted, kBuildBudget),
8287
);
8388
}
8489

@@ -94,7 +99,7 @@ class FrameTimingSummarizer {
9499
@required this.p90FrameRasterizerTime,
95100
@required this.p99FrameRasterizerTime,
96101
@required this.worstFrameRasterizerTime,
97-
@required this.missedFrameRasterizerBudget
102+
@required this.missedFrameRasterizerBudget,
98103
});
99104

100105
/// List of frame build time in microseconds
@@ -137,30 +142,32 @@ class FrameTimingSummarizer {
137142
///
138143
/// See [TimelineSummary.summaryJson] for detail.
139144
Map<String, dynamic> get summary => <String, dynamic>{
140-
'average_frame_build_time_millis':
141-
averageFrameBuildTime.inMicroseconds / 1E3,
142-
'90th_percentile_frame_build_time_millis':
143-
p90FrameBuildTime.inMicroseconds / 1E3,
144-
'99th_percentile_frame_build_time_millis':
145-
p99FrameBuildTime.inMicroseconds / 1E3,
146-
'worst_frame_build_time_millis':
147-
worstFrameBuildTime.inMicroseconds / 1E3,
148-
'missed_frame_build_budget_count': missedFrameBuildBudget,
149-
'average_frame_rasterizer_time_millis':
150-
averageFrameRasterizerTime.inMicroseconds / 1E3,
151-
'90th_percentile_frame_rasterizer_time_millis':
152-
p90FrameRasterizerTime.inMicroseconds / 1E3,
153-
'99th_percentile_frame_rasterizer_time_millis':
154-
p99FrameRasterizerTime.inMicroseconds / 1E3,
155-
'worst_frame_rasterizer_time_millis':
156-
worstFrameRasterizerTime.inMicroseconds / 1E3,
157-
'missed_frame_rasterizer_budget_count': missedFrameRasterizerBudget,
158-
'frame_count': frameBuildTime.length,
159-
'frame_build_times': frameBuildTime
160-
.map<int>((Duration datum) => datum.inMicroseconds).toList(),
161-
'frame_rasterizer_times': frameRasterizerTime
162-
.map<int>((Duration datum) => datum.inMicroseconds).toList(),
163-
};
145+
'average_frame_build_time_millis':
146+
averageFrameBuildTime.inMicroseconds / 1E3,
147+
'90th_percentile_frame_build_time_millis':
148+
p90FrameBuildTime.inMicroseconds / 1E3,
149+
'99th_percentile_frame_build_time_millis':
150+
p99FrameBuildTime.inMicroseconds / 1E3,
151+
'worst_frame_build_time_millis':
152+
worstFrameBuildTime.inMicroseconds / 1E3,
153+
'missed_frame_build_budget_count': missedFrameBuildBudget,
154+
'average_frame_rasterizer_time_millis':
155+
averageFrameRasterizerTime.inMicroseconds / 1E3,
156+
'90th_percentile_frame_rasterizer_time_millis':
157+
p90FrameRasterizerTime.inMicroseconds / 1E3,
158+
'99th_percentile_frame_rasterizer_time_millis':
159+
p99FrameRasterizerTime.inMicroseconds / 1E3,
160+
'worst_frame_rasterizer_time_millis':
161+
worstFrameRasterizerTime.inMicroseconds / 1E3,
162+
'missed_frame_rasterizer_budget_count': missedFrameRasterizerBudget,
163+
'frame_count': frameBuildTime.length,
164+
'frame_build_times': frameBuildTime
165+
.map<int>((Duration datum) => datum.inMicroseconds)
166+
.toList(),
167+
'frame_rasterizer_times': frameRasterizerTime
168+
.map<int>((Duration datum) => datum.inMicroseconds)
169+
.toList(),
170+
};
164171
}
165172

166173
// The following helper functions require data sorted
@@ -173,5 +180,6 @@ T _findPercentile<T>(List<T> data, double p) {
173180

174181
// return the number of items in data that > threshold
175182
int _countExceed<T extends Comparable<T>>(List<T> data, T threshold) {
176-
return data.length - data.indexWhere((T datum) => datum.compareTo(threshold) > 0);
183+
return data.length -
184+
data.indexWhere((T datum) => datum.compareTo(threshold) > 0);
177185
}

‎packages/e2e/pubspec.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ dependencies:
1414
sdk: flutter
1515
flutter_test:
1616
sdk: flutter
17+
path:
1718

1819
dev_dependencies:
1920
pedantic: ^1.8.0

‎packages/e2e/test/frame_timing_summarizer_test.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,11 @@ import 'package:e2e/e2e_perf.dart';
77
void main() {
88
test('Test FrameTimingSummarizer', () {
99
List<int> buildTimes = <int>[
10-
for (int i = 1; i <= 100; i += 1)
11-
1000 * i,
10+
for (int i = 1; i <= 100; i += 1) 1000 * i,
1211
];
1312
buildTimes = buildTimes.reversed.toList();
1413
List<int> rasterTimes = <int>[
15-
for (int i = 1; i <= 100; i += 1)
16-
1000 * i + 1000,
14+
for (int i = 1; i <= 100; i += 1) 1000 * i + 1000,
1715
];
1816
rasterTimes = rasterTimes.reversed.toList();
1917
List<FrameTiming> inputData = <FrameTiming>[

0 commit comments

Comments
 (0)