[path_provider] Merge iOS and macOS implementations (#6988)

* Rename directory; no changes

* Exclude new plugin from build-all during the transition

* Rename files and classes, update metadata

* Make error messages non-macOS-specific

* Move implementation to shared location

* IGNORE IN REVIEW add symlinks

* Add macOS symlink readme

* Add iOS support with sharedDarwinSource

* Add iOS example freshly created from template

* Add iOS symlinks

* Add missing library directory to example, for parity with iOS

* Move unit test to shared location, and add iOS unit test target using it

* Add the Swift search paths to podspec

* Remove path_provider_ios

* Update CODEOWNERS

* Add copyrights to example files

Author: stuartmorgan-g

CODEOWNERS

@@ -49,7 +49,7 @@ packages/image_picker/image_picker_ios/**                @vashworth
 packages/in_app_purchase/in_app_purchase_storekit/**     @cyanglaz
 packages/ios_platform_images/ios/**                      @jmagman
 packages/local_auth/local_auth_ios/**                    @hellohuanlin
-packages/path_provider/path_provider_ios/**              @jmagman
+packages/path_provider/path_provider_foundation/**       @jmagman
 packages/quick_actions/quick_actions_ios/**              @hellohuanlin
 packages/shared_preferences/shared_preferences_foundation/**  @cyanglaz
 packages/url_launcher/url_launcher_ios/**                @jmagman
@@ -64,7 +64,6 @@ packages/url_launcher/url_launcher_linux/**              @cbracken
 
 # - macOS
 packages/file_selector/file_selector_macos/**            @cbracken
-packages/path_provider/path_provider_macos/**            @cbracken
 packages/url_launcher/url_launcher_macos/**              @cbracken
 
 # - Windows

packages/path_provider/path_provider_macos/.gitignore renamed to packages/path_provider/path_provider_foundation/.gitignore

@@ -0,0 +1,5 @@
+## 2.1.0
+
+* Renames the package previously published as
+  [`path_provider_macos`](https://pub.dev/packages/path_provider_macos)
+* Adds iOS support.

packages/path_provider/path_provider_ios/AUTHORS renamed to packages/path_provider/path_provider_foundation/AUTHORS

@@ -1,6 +1,6 @@
-# path\_provider\_ios
+# path\_provider\_foundation
 
-The iOS implementation of [`path_provider`][1].
+The iOS and macOS implementation of [`path_provider`][1].
 
 ## Usage
 

packages/path_provider/path_provider_foundation/CHANGELOG.md

@@ -2,13 +2,24 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import FlutterMacOS
 import Foundation
 
+#if os(iOS)
+import Flutter
+#elseif os(macOS)
+import FlutterMacOS
+#endif
+
 public class PathProviderPlugin: NSObject, FlutterPlugin, PathProviderApi {
   public static func register(with registrar: FlutterPluginRegistrar) {
     let instance = PathProviderPlugin()
-    PathProviderApiSetup.setUp(binaryMessenger: registrar.messenger, api: instance)
+    // Workaround for https://github.com/flutter/flutter/issues/118103.
+#if os(iOS)
+    let messenger = registrar.messenger()
+#else
+    let messenger = registrar.messenger
+#endif
+    PathProviderApiSetup.setUp(binaryMessenger: messenger, api: instance)
   }
 
   func getDirectoryPath(type: DirectoryType) -> String? {

packages/path_provider/path_provider_ios/LICENSE renamed to packages/path_provider/path_provider_foundation/LICENSE

@@ -2,9 +2,14 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import FlutterMacOS
 import XCTest
-@testable import path_provider_macos
+@testable import path_provider_foundation
+
+#if os(iOS)
+import Flutter
+#elseif os(macOS)
+import FlutterMacOS
+#endif
 
 class RunnerTests: XCTestCase {
   func testGetTemporaryDirectory() throws {

packages/path_provider/path_provider_ios/README.md renamed to packages/path_provider/path_provider_foundation/README.md

@@ -0,0 +1,25 @@
+#
+# To learn more about a Podspec see http://guides.cocoapods.org/syntax/podspec.html
+#
+Pod::Spec.new do |s|
+  s.name             = 'path_provider_foundation'
+  s.version          = '0.0.1'
+  s.summary          = 'An iOS and macOS implementation of the path_provider plugin.'
+  s.description      = <<-DESC
+  An iOS and macOS implementation of the Flutter plugin for getting commonly used locations on the filesystem.
+                       DESC
+  s.homepage         = 'https://github.com/flutter/plugins/tree/main/packages/path_provider/path_provider_foundation'
+  s.license          = { :type => 'BSD', :file => '../LICENSE' }
+  s.author           = { 'Flutter Dev Team' => '[email protected]' }
+  s.source           = { :http => 'https://github.com/flutter/plugins/tree/main/packages/path_provider/path_provider_foundation' }
+  s.source_files = 'Classes/**/*'
+  s.ios.dependency 'Flutter'
+  s.osx.dependency 'FlutterMacOS'
+  s.ios.deployment_target = '9.0'
+  s.osx.deployment_target = '10.11'
+  s.ios.xcconfig = {
+    'LIBRARY_SEARCH_PATHS' => '$(TOOLCHAIN_DIR)/usr/lib/swift/$(PLATFORM_NAME)/ $(SDKROOT)/usr/lib/swift',
+    'LD_RUNPATH_SEARCH_PATHS' => '/usr/lib/swift',
+  }
+  s.swift_version = '5.0'
+end

packages/path_provider/path_provider_macos/macos/Classes/PathProviderPlugin.swift renamed to packages/path_provider/path_provider_foundation/darwin/Classes/PathProviderPlugin.swift

@@ -0,0 +1,34 @@
+**/dgph
+*.mode1v3
+*.mode2v3
+*.moved-aside
+*.pbxuser
+*.perspectivev3
+**/*sync/
+.sconsign.dblite
+.tags*
+**/.vagrant/
+**/DerivedData/
+Icon?
+**/Pods/
+**/.symlinks/
+profile
+xcuserdata
+**/.generated/
+Flutter/App.framework
+Flutter/Flutter.framework
+Flutter/Flutter.podspec
+Flutter/Generated.xcconfig
+Flutter/ephemeral/
+Flutter/app.flx
+Flutter/app.zip
+Flutter/flutter_assets/
+Flutter/flutter_export_environment.sh
+ServiceDefinitions.json
+Runner/GeneratedPluginRegistrant.*
+
+# Exceptions to above rules.
+!default.mode1v3
+!default.mode2v3
+!default.pbxuser
+!default.perspectivev3

packages/path_provider/path_provider_macos/macos/Classes/messages.g.swift renamed to packages/path_provider/path_provider_foundation/darwin/Classes/messages.g.swift

@@ -20,11 +20,7 @@
   <string>????</string>
   <key>CFBundleVersion</key>
   <string>1.0</string>
-  <key>UIRequiredDeviceCapabilities</key>
-  <array>
-    <string>arm64</string>
-  </array>
   <key>MinimumOSVersion</key>
-  <string>9.0</string>
+  <string>11.0</string>
 </dict>
 </plist>

packages/path_provider/path_provider_macos/example/macos/RunnerTests/RunnerTests.swift renamed to packages/path_provider/path_provider_foundation/darwin/Tests/RunnerTests.swift

@@ -0,0 +1,2 @@
+#include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"
+#include "Generated.xcconfig"

packages/path_provider/path_provider_foundation/darwin/path_provider_foundation.podspec

@@ -0,0 +1,2 @@
+#include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig"
+#include "Generated.xcconfig"

packages/path_provider/path_provider_ios/example/README.md renamed to packages/path_provider/path_provider_foundation/example/README.md

@@ -1,5 +1,5 @@
 # Uncomment this line to define a global platform for your project
-# platform :ios, '9.0'
+# platform :ios, '11.0'
 
 # CocoaPods analytics sends network stats synchronously affecting flutter build latency.
 ENV['COCOAPODS_DISABLE_STATS'] = 'true'
@@ -28,7 +28,11 @@ require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelpe
 flutter_ios_podfile_setup
 
 target 'Runner' do
+  use_frameworks!
+  use_modular_headers!
+
   flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))
+
   target 'RunnerTests' do
     inherit! :search_paths
   end