Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Update README example #1823

Merged
merged 5 commits into from
Jul 9, 2019
Merged

[image_picker] Update README example #1823

merged 5 commits into from
Jul 9, 2019

Conversation

MillerAdulu
Copy link
Contributor

@MillerAdulu MillerAdulu commented Jul 9, 2019

Update RetrieveLostDataResponse type to correct LostDataResponse.

Description

The RetrieveLostDataResponse type doesn't exist as part of the standard image_picker library

Related Issues

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Update `RetrieveLostDataResponse` type to correct `LostDataResponse`.

The RetrieveLostDataResponse type doesn't exist as part of the standard image_picker library
@MillerAdulu MillerAdulu requested a review from cyanglaz as a code owner July 9, 2019 13:53
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@MillerAdulu
Copy link
Contributor Author

I have signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 9, 2019
@MillerAdulu MillerAdulu changed the title Update README example [image_picker] Update README example Jul 9, 2019
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch!
Please also update the CHANGELOG and pubspec with a new version

@MillerAdulu
Copy link
Contributor Author

Done.

@cyanglaz cyanglaz merged commit 433e982 into flutter:master Jul 9, 2019
@MillerAdulu MillerAdulu deleted the patch-1 branch July 10, 2019 20:40
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants