From 01a94af911af1b628da17216d91e23da085409b0 Mon Sep 17 00:00:00 2001 From: Stuart Morgan Date: Tue, 12 Oct 2021 10:36:50 -0400 Subject: [PATCH] [ci] Always run all `format` steps The `format` task runs several independent steps, which are grouped together only to avoid unnecessary overhead from running each inexpensive check on its own VM. Since they are unrelated and inexpensive, we should always run all of them so that we can get all failures at once, rather than only seeing issues from the first failed step, and needing to potentially run through the bot three or more times to get all failures. --- .cirrus.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index ef6b9c1b6d44..3c8dd3b12ce0 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -69,8 +69,8 @@ task: - dart pub run test - name: publishable env: - # TODO (mvanbeusekom): Temporary override to "stable" because of failure on "master". - # Remove override once https://github.com/dart-lang/pub/issues/3152 is resolved. + # TODO (mvanbeusekom): Temporary override to "stable" because of failure on "master". + # Remove override once https://github.com/dart-lang/pub/issues/3152 is resolved. CHANNEL: stable CHANGE_DESC: "$TMPDIR/change-description.txt" version_check_script: @@ -88,9 +88,10 @@ task: - fi publish_check_script: ./script/tool_runner.sh publish-check - name: format - format_script: ./script/tool_runner.sh format --fail-on-change - pubspec_script: ./script/tool_runner.sh pubspec-check - license_script: dart $PLUGIN_TOOL license-check + always: + format_script: ./script/tool_runner.sh format --fail-on-change + pubspec_script: ./script/tool_runner.sh pubspec-check + license_script: dart $PLUGIN_TOOL license-check - name: federated_safety # This check is only meaningful for PRs, as it validates changes # rather than state.