From a68ddfb4cb7f3d29a4a5525a4013fe126c5c8ad4 Mon Sep 17 00:00:00 2001 From: Stuart Morgan Date: Mon, 9 May 2022 16:10:03 -0400 Subject: [PATCH] [video_player] Fix order-dependent tests Tests in this group use VideoPlayerController, which relies on the `VideoPlayerPlatform.instance`. That was not being set in this group, only an earlier group, which caused the tests to be order-dependent. Fixes b/230943469 --- packages/video_player/video_player/CHANGELOG.md | 1 + .../video_player/video_player/test/video_player_test.dart | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/packages/video_player/video_player/CHANGELOG.md b/packages/video_player/video_player/CHANGELOG.md index af01c64fd554..630459a9e498 100644 --- a/packages/video_player/video_player/CHANGELOG.md +++ b/packages/video_player/video_player/CHANGELOG.md @@ -1,6 +1,7 @@ ## NEXT * Removes unnecessary imports. +* Fixes order-dependent unit tests. ## 2.4.0 diff --git a/packages/video_player/video_player/test/video_player_test.dart b/packages/video_player/video_player/test/video_player_test.dart index 9eca7f921acb..83a49882ee9a 100644 --- a/packages/video_player/video_player/test/video_player_test.dart +++ b/packages/video_player/video_player/test/video_player_test.dart @@ -958,6 +958,13 @@ void main() { }); group('VideoPlayerOptions', () { + late FakeVideoPlayerPlatform fakeVideoPlayerPlatform; + + setUp(() { + fakeVideoPlayerPlatform = FakeVideoPlayerPlatform(); + VideoPlayerPlatform.instance = fakeVideoPlayerPlatform; + }); + test('setMixWithOthers', () async { final VideoPlayerController controller = VideoPlayerController.file( File(''),