Skip to content

Commit 1515fe7

Browse files
jmagmanflutteractionsbot
authored andcommitted
Move a few benchmarks from x64 Intel Macs to ARM (flutter#189377)
Most of the benchmarks will either run on ARM Macs-only, or run on both ARM and x64 platforms. These 3 benchmarks currently only run on x64 Intel Macs (which we are [deprecating](flutter#188328)). Move them to ARM bots. Generally we want to keep testing Intel Macs on beta and stable until current master is released, but since these 3 benchmarks should have been running on ARM, and they aren't testing anything architecture-specific, I will cherry-pick these changes to stable and beta. This will unfortunately break the historical data for these benchmarks and it will show up in skiaperf as new benchmarks. The part of flutter#189144 that should be cherry-picked to beta and stable. Fixes flutter#188851 ("fixes") Fixes flutter#189123 ("fixes") ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent ee80f08 commit 1515fe7

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

.ci.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4808,9 +4808,10 @@ targets:
48084808
task_name: hello_world_android__compile
48094809

48104810
# mac mokey benchmark
4811-
- name: Mac_mokey hot_mode_dev_cycle__benchmark
4811+
- name: Mac_arm64_mokey hot_mode_dev_cycle__benchmark
48124812
recipe: devicelab/devicelab_drone
48134813
presubmit: false
4814+
bringup: true
48144815
timeout: 60
48154816
properties:
48164817
tags: >
@@ -4848,9 +4849,10 @@ targets:
48484849
task_name: integration_ui_frame_number
48494850

48504851
# mac mokey benchmark
4851-
- name: Mac_mokey microbenchmarks
4852+
- name: Mac_arm64_mokey microbenchmarks
48524853
recipe: devicelab/devicelab_drone
48534854
presubmit: false
4855+
bringup: true
48544856
timeout: 60
48554857
properties:
48564858
tags: >
@@ -5467,9 +5469,10 @@ targets:
54675469
["devicelab", "ios", "mac"]
54685470
task_name: hot_mode_dev_cycle_ios__benchmark
54695471

5470-
- name: Mac_x64 hot_mode_dev_cycle_ios_simulator
5472+
- name: Mac_arm64 hot_mode_dev_cycle_ios_simulator
54715473
recipe: devicelab/devicelab_drone
54725474
presubmit: false
5475+
bringup: true
54735476
timeout: 60
54745477
properties:
54755478
dependencies: >-

0 commit comments

Comments
 (0)