Skip to content

Share plugin does not work on iOS when it is invalid for a view controller to be presented on iOS's root view controller #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rayliverified opened this issue May 25, 2021 · 2 comments · Fixed by #307
Closed

Share plugin does not work on iOS when it is invalid for a view controller to be presented on iOS's root view controller #251

rayliverified opened this issue May 25, 2021 · 2 comments · Fixed by #307
Labels
bug Something isn't working ios share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin

Comments

@rayliverified
Copy link
Contributor

Copied from the original share plugin at flutter/flutter#67103
There is a PR to resolve the issue that was rejected because they stopped taking PRs on the original repo.

flutter/plugins#3105

The solution looks good.
What is needed to get the fixes merged into this library?
@miquelbeltran
Copy link
Member

Anyone can copy the changes into a new PR and submit it here. Help is welcome!

@miquelbeltran miquelbeltran added bug Something isn't working ios share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin labels May 26, 2021
@rayliverified
Copy link
Contributor Author

rayliverified commented May 26, 2021 •
edited
Loading

@sianxz I'm going to go ahead and copy your commit into the new repo so your great work doesn't go to waste. Hope you don't mind!

@rayliverified rayliverified mentioned this issue May 26, 2021
Closed
9 tasks
@miquelbeltran miquelbeltran mentioned this issue Jun 15, 2021
Merged
@miquelbeltran miquelbeltran mentioned this issue Jun 15, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working ios share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin
Projects
None yet
Milestone
No milestone
2 participants
@miquelbeltran @rayliverified