Remove file reading from bootstrap package #3249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
bootstrap/files
branch
from
116f6de to
30ed396
Compare
phillebaba
commented
Oct 25, 2022
| } | ||
|
|
||
| // Return early if exists and no custom config is passed | ||
| if ok && len(options.CAFilePath+options.PrivateKeyPath+options.Username+options.Password) == 0 { |
Member
Author
There was a problem hiding this comment.
Verify that this logic is the same as the previous.
phillebaba
force-pushed
the
bootstrap/files
branch
11 times, most recently
from
7280d17 to
e658b37
Compare
pjbgf
reviewed
Nov 1, 2022
pjbgf
reviewed
Nov 1, 2022
phillebaba
force-pushed
the
bootstrap/files
branch
2 times, most recently
from
b757e53 to
8ce6863
Compare
Signed-off-by: Philip Laine <[email protected]>
phillebaba
force-pushed
the
bootstrap/files
branch
from
8ce6863 to
a4734d7
Compare
pjbgf
reviewed
Nov 4, 2022
| } | ||
|
|
||
| // Bootstrap config | ||
|
|
stefanprodan
approved these changes
Nov 4, 2022
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @phillebaba 🏅
pjbgf
approved these changes
Nov 4, 2022
Member
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
Apart from the nit, LGTM
Thanks @phillebaba! 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves all file reading for certificates and PGP from code located in pkg to the CLI command. The purpose for this is to make sharing the code easier where the content is not expected to be in files.