Refactor bootstrap process to use fluxcd/pkg/git
#3299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
requested review from
hiddeco,
phillebaba and
stefanprodan
and removed request for
hiddeco and
phillebaba
pjbgf
reviewed
Nov 8, 2022
aryan9600
force-pushed
the
use-pkg-git
branch
from
b02c500 to
007e0a3
Compare
Member
Author
|
commands and providers tested:
|
pjbgf
reviewed
Nov 9, 2022
aryan9600
force-pushed
the
use-pkg-git
branch
2 times, most recently
from
3601f85 to
77ff5fd
Compare
pjbgf
reviewed
Nov 9, 2022
pjbgf
reviewed
Nov 9, 2022
Member
|
Tested the bootstrap with GPG signing, which worked fine in GitHub: |
aryan9600
changed the title
aryan9600
force-pushed
the
use-pkg-git
branch
from
cb14af2 to
dd6ddf2
Compare
pjbgf
reviewed
Nov 10, 2022
aryan9600
force-pushed
the
use-pkg-git
branch
from
dd6ddf2 to
f2d2d00
Compare
stefanprodan
approved these changes
Nov 11, 2022
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @aryan9600 🏅
stefanprodan
changed the title
fluxcd/pkg/git
pjbgf
reviewed
Nov 14, 2022
Member
|
@stefanprodan please review the latest changes from an UX PoV. They were required due to the CodeCommit workflow for non |
Member
|
@aryan9600 @pjbgf I don't understand why is the SSH username a prompt instead of a flag to set it. I also don't understand how and why is this used. Please post an example for AWS CodeCommit to show case what this does. |
Member
|
I propose we undo the flux bootstrap git \
--url ssh://SSH-Key-ID@git-codecommit.<region>.amazonaws.com/v1/repos/<repository> \
--private-key-file=<path/to/private.key>We could add a regex for AWS CodeCommit SSH URLs and error out if the private key is not supplied. We also need to add an example like the above to the command help. |
aryan9600
force-pushed
the
use-pkg-git
branch
from
8a443ee to
1029892
Compare
aryan9600
force-pushed
the
use-pkg-git
branch
2 times, most recently
from
ac860e6 to
62db2d1
Compare
aryan9600
force-pushed
the
use-pkg-git
branch
3 times, most recently
from
5f5bf41 to
b5ac7f1
Compare
pjbgf
reviewed
Nov 17, 2022
pjbgf
reviewed
Nov 17, 2022
aryan9600
force-pushed
the
use-pkg-git
branch
2 times, most recently
from
cfbf96b to
45e10f0
Compare
pjbgf
approved these changes
Nov 17, 2022
Member
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
LGTM
Awesome work @aryan9600! 🙇
Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
Signed-off-by: Sanskar Jaiswal <[email protected]>
aryan9600
force-pushed
the
use-pkg-git
branch
from
45e10f0 to
6d2cbca
Compare
Signed-off-by: Sanskar Jaiswal <[email protected]>
aryan9600
force-pushed
the
use-pkg-git
branch
from
6d2cbca to
35e1b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the bootstrap process to use https://github.com/fluxcd/pkg/tree/main/git/gogit, getting rid of the
pkg/bootstrap/gitin the process.Fixes: #3273
Related to: #3282
Signed-off-by: Sanskar Jaiswal [email protected]