Skip to content

Conversation

@onedr0p
Copy link
Contributor

@onedr0p onedr0p commented May 10, 2023

This change would be nice to get in because MUSL finally implemented TCP fallback in their DNS resolver.

alpinelinux.org/posts/Alpine-3.18.0-released.html

@hiddeco
Copy link
Member

hiddeco commented May 10, 2023

DCO sign-off is required.

This change would be nice to get in because MUSL finally implemented TCP fallback in their DNS resolver.

alpinelinux.org/posts/Alpine-3.18.0-released.html

Signed-off-by: Devin Buhl <[email protected]>
@hiddeco hiddeco added the area/ci CI related issues and pull requests label May 10, 2023
@onedr0p
Copy link
Contributor Author

onedr0p commented May 10, 2023

Whoops.. Should I also do that on the other PRs I opened? Those looked happy at least.

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub is degraded (again), but looks good to me.

@hiddeco
Copy link
Member

hiddeco commented May 10, 2023

Whoops.. Should I also do that on the other PRs I opened? Those looked happy at least.

I went and checked, and at least one of them had a sign-off.

@hiddeco
Copy link
Member

hiddeco commented May 10, 2023

@onedr0p if you feel adventurous, there are some other places where this update is required: https://github.com/search?q=org%3Afluxcd+alpine+language%3ADockerfile&type=code&l=Dockerfile

@onedr0p
Copy link
Contributor Author

onedr0p commented May 10, 2023

Sure I can try to take a stab at those later today. I am just happy to have TCP fallback on Alpine... FINALLY.

@hiddeco hiddeco merged commit 70546e5 into fluxcd:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI related issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants