Skip to content

Commit 11c9e35

Browse files
authored
Merge pull request #139 from fractalego/deactivate-resets-rules-and-memory
resetting rules and memory upon deactivation
2 parents 9084cea + 4cf5199 commit 11c9e35

File tree

5 files changed

+11
-5
lines changed

5 files changed

+11
-5
lines changed

todo.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
* delete rules and memory from discourse_answerer
2+
13
* This is wrong - from wafl_ll
24
<|end|><|assistant|><|user|> Hi!<|end|><|assistant|>
35
The user is sandwiched between the assistant. It should be:

wafl/answerer/base_answerer.py

Lines changed: 0 additions & 3 deletions
This file was deleted.

wafl/answerer/dialogue_answerer.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,14 @@
1313
create_memory_from_fact_list,
1414
select_best_rules_using_entailer,
1515
)
16-
from wafl.answerer.base_answerer import BaseAnswerer
1716
from wafl.answerer.rule_maker import RuleMaker
1817
from wafl.connectors.clients.llm_chat_client import LLMChatClient
1918
from wafl.data_objects.dataclasses import Query, Answer
2019
from wafl.interface.conversation import Conversation, Utterance
2120
from wafl.simple_text_processing.questions import is_question
2221

2322

24-
class DialogueAnswerer(BaseAnswerer):
23+
class DialogueAnswerer:
2524
def __init__(self, config, knowledge, interface, code_path, logger):
2625
self._threshold_for_facts = 0.85
2726
self._client = LLMChatClient(config)
@@ -43,6 +42,10 @@ def __init__(self, config, knowledge, interface, code_path, logger):
4342
max_num_rules=1,
4443
)
4544

45+
def reset(self):
46+
self._prior_facts = []
47+
self._prior_rules = []
48+
4649
async def answer(self, query_text: str) -> Answer:
4750
if self._logger:
4851
self._logger.write(f"Dialogue Answerer: the query is {query_text}")

wafl/events/conversation_events.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,9 @@ def __init__(
4141
if logger:
4242
self._logger.set_depth(0)
4343

44+
def reset(self):
45+
self._answerer.reset()
46+
4447
async def output(self, text: str):
4548
await self._interface.output(text)
4649

wafl/handlers/conversation_handler.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ async def _main_loop(self):
6666
and interactions == 1
6767
):
6868
self._interface.deactivate()
69+
self._conversation_events.reset()
6970
num_misses = 0
7071

7172
if (

0 commit comments

Comments
 (0)