Skip to content

New component Popover #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
div-Leo opened this issue Apr 7, 2022 · 5 comments · Fixed by #230 or #234
Closed

New component Popover #213

div-Leo opened this issue Apr 7, 2022 · 5 comments · Fixed by #230 or #234
Assignees
Labels

Comments

@div-Leo
Copy link
Contributor

div-Leo commented Apr 7, 2022

Describe the feature you'd like

We need a new component that has the behavior of a Popover. Here have a draft of the component. It contains also some examples and a possible idea for implementation (to be discussed).

Describe alternatives you've considered

Currently, in the DS, we have a Tooltip component that is being used wrongly. We want to have a component that opens next to a target by clicking on it and stays open when we move the cursor.

@div-Leo div-Leo added the enhancement New feature or request label Apr 7, 2022
@JanHamara
Copy link
Contributor

Hello everyone, I have one consideration to comment to this from my research on replacement components from Wave for BOMT :)

Component concerned is ManageBookingDropdown which still uses the deprecated @mytaxi/react-component-button-dropdown and needs a suitable replacement from Wave.

As it is a button element that triggers a dropdown (be it, with some links), I feel like this new Popover component could be an ideal solution for this :)

Things to consider:

  • are we okay for Popup content to contain links?
  • we would need the Trigger to look exactly like Wave Button + with an icon

More context

Manage Booking Button

@rafael-sepeda
Copy link

rafael-sepeda commented Apr 19, 2022

@JanHamara we have similar use cases in GAME and Admin panel : a button that shows a context menu

@div-Leo
Copy link
Contributor Author

div-Leo commented Apr 19, 2022

@JanHamara, yes that would be a possible usage. I think the idea is to have flexible content/triggers.
As @rafael-sepeda mentioned we have already a couple of examples to give a better idea of the possible use cases, see also BulkActions in DMT.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

🎉 This issue has been resolved in version 1.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants