fix: Deploy community ssh-keys only if community is explicitly set #1474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only deploy ssh keys ment for maintenance by the community if the community attribute is explicitly set. Otherwise an undefined community attribute deploys ssh keys silently and without warning on private installations. This new behavior seems to be inline with other uses of the community attribute in the code. This change may break standard behavior and requires us to add another commit that adds the community attribute explicitly to all community maintained installations.
booo
force-pushed
the
fix/community-ssh-keys
branch
from
594e5e9 to
d2cedd4
Compare
Noki
requested changes
Dec 3, 2025
| merged_var_name: ssh_keys | ||
| expected_type: list | ||
| when: ssh_keys is undefined | ||
| when: ssh_keys is undefined and (community is defined and community|bool == True) |
Member
There was a problem hiding this comment.
This will remove the community keys from locations like segen, lause, perleberger36 and many more and cause us to loose access to these locations. These locations currently have a named maintainer, but are still considered community locations in the sense of having access by having all community keys installed. This is therefore a breaking change and should not be merged like this.
You should introduce a setting community_access: true and also add this to all existing locations that are affected by this change.
Member
Author
There was a problem hiding this comment.
Adding community_access sounds like a good plan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only deploy ssh keys ment for maintenance by the community if the community attribute is explicitly set. Otherwise an undefined community attribute deploys ssh keys silently and without warning on private installations. This new behavior seems to be inline with other uses of the community attribute in the code.
This change may break standard behavior and requires us to add another commit that adds the community attribute explicitly to all community maintained installations.