make_bucket_versioned method (#825)

Author: martindurant

s3fs/core.py

@@ -1943,6 +1943,17 @@ async def _is_bucket_versioned(self, bucket):
 
     is_bucket_versioned = sync_wrapper(_is_bucket_versioned)
 
+    async def _make_bucket_versioned(self, bucket, versioned: bool = True):
+        """Set bucket versioning status"""
+        status = "Enabled" if versioned else "Suspended"
+        return await self._call_s3(
+            "put_bucket_versioning",
+            Bucket=bucket,
+            VersioningConfiguration={"Status": status},
+        )
+
+    make_bucket_versioned = sync_wrapper(_make_bucket_versioned)
+
     async def _rm_versioned_bucket_contents(self, bucket):
         """Remove a versioned bucket and all contents"""
         await self.set_session()
@@ -2294,7 +2305,7 @@ def commit(self):
             if self.buffer is not None:
                 logger.debug("Empty file committed %s" % self)
                 self._abort_mpu()
-                write_result = self.fs.touch(self.path)
+                write_result = self.fs.touch(self.path, **self.kwargs)
         elif not self.parts:
             if self.buffer is not None:
                 logger.debug("One-shot upload of %s" % self)

s3fs/tests/test_s3fs.py

@@ -2729,3 +2729,12 @@ def test_cache_handles_find_with_maxdepth(s3):
         assert base_name + "/dir1/fileB" not in f
 
         s3.invalidate_cache()
+
+
+def test_bucket_versioning(s3):
+    s3.mkdir("maybe_versioned")
+    assert not s3.is_bucket_versioned("maybe_versioned")
+    s3.make_bucket_versioned("maybe_versioned")
+    assert s3.is_bucket_versioned("maybe_versioned")
+    s3.make_bucket_versioned("maybe_versioned", False)
+    assert not s3.is_bucket_versioned("maybe_versioned")