Skip to content

Commit 1ade2b1

Browse files
committed
add support for create cert with CSR data
1 parent ef48698 commit 1ade2b1

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

src/Certes/AcmeClient.cs

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -227,12 +227,10 @@ public async Task<AcmeResult<Challenge>> CompleteChallenge(Challenge authChallen
227227
/// <summary>
228228
/// Creates a new certificate.
229229
/// </summary>
230-
/// <param name="csrProvider">The certificate signing request (CSR) provider.</param>
230+
/// <param name="csrBytes">The certificate signing request data.</param>
231231
/// <returns>The certificate issued.</returns>
232-
public async Task<AcmeCertificate> NewCertificate(ICertificationRequestBuilder csrProvider)
232+
public async Task<AcmeCertificate> NewCertificate(byte[] csrBytes)
233233
{
234-
var csrBytes = csrProvider.Generate();
235-
236234
var payload = new Certificate
237235
{
238236
Csr = JwsConvert.ToBase64String(csrBytes),
@@ -252,7 +250,6 @@ public async Task<AcmeCertificate> NewCertificate(ICertificationRequestBuilder c
252250
var cert = new AcmeCertificate
253251
{
254252
Raw = result.Raw,
255-
Key = csrProvider.Export(),
256253
Links = result.Links,
257254
Location = result.Location,
258255
ContentType = result.ContentType
@@ -284,6 +281,19 @@ public async Task<AcmeCertificate> NewCertificate(ICertificationRequestBuilder c
284281
return cert;
285282
}
286283

284+
/// <summary>
285+
/// Creates a new certificate.
286+
/// </summary>
287+
/// <param name="csrProvider">The certificate signing request (CSR) provider.</param>
288+
/// <returns>The certificate issued.</returns>
289+
public async Task<AcmeCertificate> NewCertificate(ICertificationRequestBuilder csrProvider)
290+
{
291+
var csrBytes = csrProvider.Generate();
292+
var cert = await NewCertificate(csrBytes);
293+
cert.Key = csrProvider.Export();
294+
return cert;
295+
}
296+
287297
/// <summary>
288298
/// Revokes the certificate.
289299
/// </summary>

0 commit comments

Comments
 (0)