Add support for decoding registered CBOR tag to interface type #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify decoder to create new value of registered type and decode data to that value when unmarshaling CBOR data with registered tag to interface type.
|
Works like a charm for my usecase. I think it might be important to specify that the value in the struct will always be a pointer. |
I'll add a comment in the code for godoc and maybe also update the README to make this limitation clearer. I need to find time to update the fuzz test and run it before merging. Likely this month unless something crazy unexpected happens. Thanks again for requesting this and providing valuable feedback! |
fxamacker
deleted the
fxamacker/decode-registered-cbor-tag-to-registered-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #301
Modify decoder to create new value of registered type and decode data to that value when unmarshaling CBOR data with registered tag to interface type.