Skip to content

Commit 2a8342e

Browse files
author
Gabriel Schulhof
committed
test,n-api: delete strong ref w/o unrefing first
Re: nodejs#34731 Signed-off-by: Gabriel Schulhof <[email protected]>
1 parent 0e30c5b commit 2a8342e

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

test/node-api/test_worker_terminate_finalization/test.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
'use strict';
22
const common = require('../../common');
33

4-
// TODO(addaleax): Run this test once it stops failing under ASAN/valgrind.
5-
// Refs: https://github.com/nodejs/node/issues/34731
6-
common.skip('Reference management in N-API leaks memory');
7-
84
const { Worker, isMainThread } = require('worker_threads');
95

106
if (isMainThread) {

test/node-api/test_worker_terminate_finalization/test_worker_terminate_finalization.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ int wrappedNativeData;
1010
napi_ref ref;
1111
void WrapFinalizer(napi_env env, void* data, void* hint) {
1212
uint32_t count;
13-
NAPI_CALL_RETURN_VOID(env, napi_reference_unref(env, ref, &count));
1413
NAPI_CALL_RETURN_VOID(env, napi_delete_reference(env, ref));
1514
}
1615

0 commit comments

Comments
 (0)