Skip to content

Commit 6b33d24

Browse files
committed
Enable skipped tests from facebook#21723
1 parent e577bfb commit 6b33d24

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

packages/react-dom/src/__tests__/ReactDOMConsoleErrorReporting-test.js

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -313,8 +313,7 @@ describe('ReactDOMConsoleErrorReporting', () => {
313313
}
314314
});
315315

316-
// TODO: this is broken due to https://github.com/facebook/react/issues/21712.
317-
xit('logs layout effect errors without an error boundary', () => {
316+
it('logs layout effect errors without an error boundary', () => {
318317
spyOnDevAndProd(console, 'error');
319318

320319
function Foo() {
@@ -382,8 +381,7 @@ describe('ReactDOMConsoleErrorReporting', () => {
382381
}
383382
});
384383

385-
// TODO: this is broken due to https://github.com/facebook/react/issues/21712.
386-
xit('logs layout effect errors with an error boundary', () => {
384+
it('logs layout effect errors with an error boundary', () => {
387385
spyOnDevAndProd(console, 'error');
388386

389387
function Foo() {
@@ -453,8 +451,7 @@ describe('ReactDOMConsoleErrorReporting', () => {
453451
}
454452
});
455453

456-
// TODO: this is broken due to https://github.com/facebook/react/issues/21712.
457-
xit('logs passive effect errors without an error boundary', () => {
454+
it('logs passive effect errors without an error boundary', () => {
458455
spyOnDevAndProd(console, 'error');
459456

460457
function Foo() {
@@ -522,8 +519,7 @@ describe('ReactDOMConsoleErrorReporting', () => {
522519
}
523520
});
524521

525-
// TODO: this is broken due to https://github.com/facebook/react/issues/21712.
526-
xit('logs passive effect errors with an error boundary', () => {
522+
it('logs passive effect errors with an error boundary', () => {
527523
spyOnDevAndProd(console, 'error');
528524

529525
function Foo() {
@@ -827,8 +823,7 @@ describe('ReactDOMConsoleErrorReporting', () => {
827823
}
828824
});
829825

830-
// TODO: this is broken due to https://github.com/facebook/react/issues/21712.
831-
xit('logs layout effect errors without an error boundary', () => {
826+
it('logs layout effect errors without an error boundary', () => {
832827
spyOnDevAndProd(console, 'error');
833828

834829
function Foo() {
@@ -898,8 +893,7 @@ describe('ReactDOMConsoleErrorReporting', () => {
898893
}
899894
});
900895

901-
// TODO: this is broken due to https://github.com/facebook/react/issues/21712.
902-
xit('logs layout effect errors with an error boundary', () => {
896+
it('logs layout effect errors with an error boundary', () => {
903897
spyOnDevAndProd(console, 'error');
904898

905899
function Foo() {
@@ -972,8 +966,7 @@ describe('ReactDOMConsoleErrorReporting', () => {
972966
}
973967
});
974968

975-
// TODO: this is broken due to https://github.com/facebook/react/issues/21712.
976-
xit('logs passive effect errors without an error boundary', () => {
969+
it('logs passive effect errors without an error boundary', () => {
977970
spyOnDevAndProd(console, 'error');
978971

979972
function Foo() {
@@ -1043,8 +1036,7 @@ describe('ReactDOMConsoleErrorReporting', () => {
10431036
}
10441037
});
10451038

1046-
// TODO: this is broken due to https://github.com/facebook/react/issues/21712.
1047-
xit('logs passive effect errors with an error boundary', () => {
1039+
it('logs passive effect errors with an error boundary', () => {
10481040
spyOnDevAndProd(console, 'error');
10491041

10501042
function Foo() {

0 commit comments

Comments
 (0)