fix: cannot read property 'split' of undefined#225
Merged
gajus merged 3 commits intogajus:masterfrom Feb 19, 2019
AlbertLucianto:master
Merged
fix: cannot read property 'split' of undefined#225gajus merged 3 commits intogajus:masterfrom AlbertLucianto:master
gajus merged 3 commits intogajus:masterfrom
AlbertLucianto:master
Conversation
Owner
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #128
In
getClassName, falsey values will return an empty string.Empty string is returned instead of its own value, because in cases such as
<div className="a" styleName={null} />, the resulting className should not be"a null".