fix: improve reliability by removing config store file lock #7237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen some users encountering error messages when Garden couldn't acquire the config store lock. We're already preventing data corruption on concurrent modification by relying on atomically writing by creating a new file and moving it. This commit changes the lock mechanism to only protect concurrent writes from the same garden process, but we accept data loss in the unlikely event another garden process also updates the config store at the same time (one of the writes will win).
vvagaytsev
approved these changes
May 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We've seen some users encountering error messages when Garden couldn't
acquire the config store lock.
We're already preventing data corruption on concurrent modification by
relying on atomically writing by creating a new file and moving it.
This commit changes the lock mechanism to only protect concurrent writes
from the same garden process, but we accept data loss in the unlikely
event another garden process also updates the config store at the same
time (one of the writes will win).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: