fix(gatsby): respect node type owner in deleteNode (#13492)

Author: frinyvonnick

packages/gatsby/src/db/__tests__/nodes.js

@@ -349,6 +349,32 @@ describe(`nodes db tests`, () => {
     expect(report.warn).toHaveBeenCalledWith(deprecationNotice)
   })
 
+  it(`throws an error when trying to delete a node of a type owned from another plugin`, () => {
+    expect(() => {
+      store.dispatch(
+        actions.createNode(
+          {
+            id: `hi`,
+            children: [],
+            parent: `test`,
+            internal: {
+              contentDigest: `hasdfljds`,
+              type: `Other`,
+            },
+          },
+          {
+            name: `other`,
+          }
+        )
+      )
+      store.dispatch(
+        actions.deleteNode(`hi`, getNode(`hi`), {
+          name: `tests`,
+        })
+      )
+    }).toThrow(/deleted/)
+  })
+
   it(`does not crash when delete node is called on undefined`, () => {
     actions.deleteNode(undefined, {
       name: `tests`,

packages/gatsby/src/redux/actions.js

@@ -403,6 +403,26 @@ actions.deleteNode = (options: any, plugin: Plugin, args: any) => {
   // Always get node from the store, as the node we get as an arg
   // might already have been deleted.
   const node = getNode(id)
+  if (plugin) {
+    const pluginName = plugin.name
+
+    if (node && typeOwners[node.internal.type] !== pluginName)
+      throw new Error(stripIndent`
+          The plugin "${pluginName}" deleted a node of a type owned by another plugin.
+
+          The node type "${node.internal.type}" is owned by "${
+        typeOwners[node.internal.type]
+      }".
+
+          The node object passed to "deleteNode":
+
+          ${JSON.stringify(node, null, 4)}
+
+          The plugin deleting the node:
+
+          ${JSON.stringify(plugin, null, 4)}
+        `)
+  }
 
   const createDeleteAction = node => {
     return {