Skip to content

add types for gatsby-image/withIEPolyfill to fix #14592#14641

Merged
freiksenet merged 2 commits intogatsbyjs:masterfrom
janKir:topics/gatsby-image-ie-polyfill-types
Jun 10, 2019
Merged

add types for gatsby-image/withIEPolyfill to fix #14592#14641
freiksenet merged 2 commits intogatsbyjs:masterfrom
janKir:topics/gatsby-image-ie-polyfill-types

Conversation

@janKir
Copy link
Copy Markdown
Contributor

@janKir janKir commented Jun 8, 2019

Description

add types for gatsby-image/withIEPolyfill

Related Issues

fixes #14592

@janKir janKir requested a review from a team June 8, 2019 09:58
Copy link
Copy Markdown
Contributor

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @janKir! Just one more thing:

Comment thread packages/gatsby-image/withIEPolyfill/index.d.ts Outdated
@freiksenet freiksenet merged commit 39b1c6e into gatsbyjs:master Jun 10, 2019
@gatsbot
Copy link
Copy Markdown

gatsbot Bot commented Jun 10, 2019

Holy buckets, @janKir — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@freiksenet
Copy link
Copy Markdown
Contributor

Thank you!

mxxk pushed a commit to mxxk/gatsby that referenced this pull request Jun 21, 2019
…atsbyjs#14592 (gatsbyjs#14641)

* add types for gatsby-image/withIEPolyfill

* remove state generic
raffishquartan pushed a commit to raffishquartan/gatsby that referenced this pull request Apr 28, 2026
…atsbyjs#14592 (gatsbyjs#14641)

* add types for gatsby-image/withIEPolyfill

* remove state generic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gatsby-image/withIEPolyfill is missing typings

3 participants