fix: copy the output of Slot() to avoir concurrency issue (#35)

gballet · holiman · web-flow · commit 5bb6607a9f81 · 2022-05-31T17:33:57.000+02:00
Co-authored-by: Martin Holst Swende &lt;martin@swende.se&gt;
diff --git a/cmd/geth/converkle.go b/cmd/geth/converkle.go
@@ -142,9 +142,11 @@ type slotHash struct {
 func iterateSlots(slotCh chan *slotHash, storageIt snapshot.StorageIterator) {
 	defer storageIt.Release()
 	for storageIt.Next() {
+		var slot [32]byte
+		copy(slot[:], storageIt.Slot())
 		slotCh <- &slotHash{
 			hash: storageIt.Hash(),
-			slot: storageIt.Slot(),
+			slot: slot[:],
 		}
 	}
 	if storageIt.Error() != nil {

Original file line number	Diff line number	Diff line change
`@@ -142,9 +142,11 @@ type slotHash struct {`
`142`	`142`	`func iterateSlots(slotCh chan *slotHash, storageIt snapshot.StorageIterator) {`
`143`	`143`	`defer storageIt.Release()`
`144`	`144`	`for storageIt.Next() {`
	`145`	`+ var slot [32]byte`
	`146`	`+ copy(slot[:], storageIt.Slot())`
`145`	`147`	`slotCh <- &slotHash{`
`146`	`148`	`hash: storageIt.Hash(),`
`147`		`- slot: storageIt.Slot(),`
	`149`	`+ slot: slot[:],`
`148`	`150`	`}`
`149`	`151`	`}`
`150`	`152`	`if storageIt.Error() != nil {`