Add option to ensure all dialects are properly tested in CI (#526)

Author: adrien-berchet

.github/workflows/test_and_publish.yml

@@ -153,8 +153,9 @@ jobs:
         PYTEST_MYSQL_DB_URL: mysql://gis:gis@127.0.0.1:3307/gis
         PYTEST_MARIADB_DB_URL: mariadb://gis:gis@127.0.0.1:3308/gis
       run: |
+        export PYTEST_ADDOPTS='--require-all-dialects'
         if [[ ${{ matrix.python-version.flag }} == 'pypy3.8' ]]; then
-          export PYTEST_ADDOPTS='--ignore=tests/gallery/test_insert_raster.py'
+          export PYTEST_ADDOPTS=${PYTEST_ADDOPTS}' --ignore=tests/gallery/test_insert_raster.py'
         fi;
         # Run the unit test suite with SQLAlchemy=1.4.* and then with the latest version of SQLAlchemy
         tox -vv

tests/conftest.py

@@ -57,6 +57,12 @@ def pytest_addoption(parser):
         default=False,
         help="If set to True, all statements of the engine are logged.",
     )
+    parser.addoption(
+        "--require-all-dialects",
+        action="store_true",
+        default=False,
+        help="If set to True, all dialects muts be properly executed.",
+    )
 
 
 def pytest_generate_tests(metafunc):
@@ -173,8 +179,14 @@ def _engine_echo(request):
     return _engine_echo
 
 
+@pytest.fixture(scope="session")
+def _require_all_dialects(request):
+    _require_all_dialects = request.config.getoption("--require-all-dialects")
+    return _require_all_dialects
+
+
 @pytest.fixture
-def engine(tmpdir, db_url, _engine_echo):
+def engine(tmpdir, db_url, _engine_echo, _require_all_dialects):
     """Provide an engine to test database."""
     try:
         if db_url.startswith("sqlite:///"):
@@ -196,7 +208,11 @@ def engine(tmpdir, db_url, _engine_echo):
             current_engine = create_engine(db_url, echo=_engine_echo)
             current_engine.update_execution_options(search_path=["gis", "public"])
     except Exception:
-        pytest.skip(reason=f"Could not create engine for this URL: {db_url}")
+        msg = f"Could not create engine for this URL: {db_url}"
+        if _require_all_dialects:
+            pytest.fail("All dialects are required. " + msg)
+        else:
+            pytest.skip(reason=msg)
 
     # Disambiguate MySQL and MariaDB
     if current_engine.dialect.name in ["mysql", "mariadb"]:
@@ -208,9 +224,17 @@ def engine(tmpdir, db_url, _engine_echo):
                     else "MySQL"
                 )
             if current_engine.dialect.name != mysql_type.lower():
-                pytest.skip(reason=f"Can not execute {mysql_type} queries on {db_url}")
+                msg = f"Can not execute {mysql_type} queries on {db_url}"
+                if _require_all_dialects:
+                    pytest.fail("All dialects are required. " + msg)
+                else:
+                    pytest.skip(reason=msg)
         except InvalidRequestError:
-            pytest.skip(reason=f"Can not execute MariaDB queries on {db_url}")
+            msg = f"Can not execute MariaDB queries on {db_url}"
+            if _require_all_dialects:
+                pytest.fail("All dialects are required. " + msg)
+            else:
+                pytest.skip(reason=msg)
 
     yield current_engine
     current_engine.dispose()