kdtree.h: make coverity scan happy

rouault · rouault · commit 5bbb457e1f96 · 2026-02-20T05:12:18.000+01:00
diff --git a/frmts/nitf/kdtree.h b/frmts/nitf/kdtree.h
@@ -229,7 +229,7 @@ template <class T> class PNNKDTree
     int insert(std::vector<BucketItem<T>> &&vectors, const T &ctxt);
 
     /** Iterate over leaf nodes (that contain buckets) */
-    void iterateOverLeaves(std::function<void(PNNKDTree &)> f);
+    void iterateOverLeaves(const std::function<void(PNNKDTree &)> &f);
 
     /** Perform clustering to reduce the number of buckets from initialBucketCount
      * to targetCount.
@@ -661,7 +661,7 @@ int PNNKDTree<T>::insert(std::vector<BucketItem<T>> &&vectors, int totalCount,
 /************************************************************************/
 
 template <class T>
-void PNNKDTree<T>::iterateOverLeaves(std::function<void(PNNKDTree &)> f)
+void PNNKDTree<T>::iterateOverLeaves(const std::function<void(PNNKDTree &)> &f)
 {
     if (m_left && m_right)
     {

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ template <class T> class PNNKDTree`
`229`	`229`	`int insert(std::vector<BucketItem<T>> &&vectors, const T &ctxt);`
`230`	`230`
`231`	`231`	`/** Iterate over leaf nodes (that contain buckets) */`
`232`		`- void iterateOverLeaves(std::function<void(PNNKDTree &)> f);`
	`232`	`+ void iterateOverLeaves(const std::function<void(PNNKDTree &)> &f);`
`233`	`233`
`234`	`234`	`/** Perform clustering to reduce the number of buckets from initialBucketCount`
`235`	`235`	`* to targetCount.`
`@@ -661,7 +661,7 @@ int PNNKDTree<T>::insert(std::vector<BucketItem<T>> &&vectors, int totalCount,`
`661`	`661`	`/************************************************************************/`
`662`	`662`
`663`	`663`	`template <class T>`
`664`		`-void PNNKDTree<T>::iterateOverLeaves(std::function<void(PNNKDTree &)> f)`
	`664`	`+void PNNKDTree<T>::iterateOverLeaves(const std::function<void(PNNKDTree &)> &f)`
`665`	`665`	`{`
`666`	`666`	`if (m_left && m_right)`
`667`	`667`	`{`