Skip to content

Commit c8f5e0c

Browse files
don1989don1989
committed
fix(ori-2666): update tests now asset_external_id is required.
1 parent 75e9677 commit c8f5e0c

File tree

2 files changed

+4
-90
lines changed

2 files changed

+4
-90
lines changed

‎original_sdk/tests/e2e/test_async_client_e2e.py

Lines changed: 2 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -150,51 +150,6 @@ async def test_create_asset_with_mint_price(
150150
response = await async_client.create_asset(**request_data)
151151
assert response["data"]["uid"] is not None
152152

153-
async def test_create_asset_with_deprecated_client_id(
154-
self, async_client: OriginalAsyncClient
155-
):
156-
asset_name = get_random_string(8)
157-
asset_data = {
158-
"name": asset_name,
159-
"unique_name": True,
160-
"image_url": "https://example.com/image.png",
161-
"store_image_on_ipfs": False,
162-
"attributes": [
163-
{"trait_type": "Eyes", "value": "Green"},
164-
{"trait_type": "Hair", "value": "Black"},
165-
],
166-
}
167-
request_data = {
168-
"data": asset_data,
169-
"user_uid": TEST_APP_USER_UID,
170-
"client_id": asset_name,
171-
"collection_uid": TEST_APP_COLLECTION_UID,
172-
}
173-
response = await async_client.create_asset(**request_data)
174-
assert response["data"]["uid"] is not None
175-
176-
async def test_create_asset_with_no_client_id(
177-
self, async_client: OriginalAsyncClient
178-
):
179-
asset_name = get_random_string(8)
180-
asset_data = {
181-
"name": asset_name,
182-
"unique_name": True,
183-
"image_url": "https://example.com/image.png",
184-
"store_image_on_ipfs": False,
185-
"attributes": [
186-
{"trait_type": "Eyes", "value": "Green"},
187-
{"trait_type": "Hair", "value": "Black"},
188-
],
189-
}
190-
request_data = {
191-
"data": asset_data,
192-
"user_uid": TEST_APP_USER_UID,
193-
"collection_uid": TEST_APP_COLLECTION_UID,
194-
}
195-
response = await async_client.create_asset(**request_data)
196-
assert response["data"]["uid"] is not None
197-
198153
async def test_edit_asset(self, async_client: OriginalAsyncClient):
199154
asset_name = get_random_string(8)
200155
asset_data = {
@@ -211,7 +166,7 @@ async def test_edit_asset(self, async_client: OriginalAsyncClient):
211166
request_data = {
212167
"data": asset_data,
213168
"user_uid": TEST_APP_USER_UID,
214-
"client_id": asset_name,
169+
"asset_external_id": asset_name,
215170
"collection_uid": TEST_APP_COLLECTION_UID,
216171
}
217172
asset_response = await async_client.create_asset(**request_data)
@@ -362,7 +317,7 @@ async def test_full_create_transfer_burn_asset_flow(
362317
request_data = {
363318
"data": asset_data,
364319
"user_uid": TEST_APP_USER_UID,
365-
"client_id": asset_name,
320+
"asset_external_id": asset_name,
366321
"collection_uid": TEST_APP_COLLECTION_UID,
367322
}
368323
asset_response = await async_client.create_asset(**request_data)

‎original_sdk/tests/e2e/test_client_e2e.py

Lines changed: 2 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -135,47 +135,6 @@ def test_create_asset_with_mint_price(self, client: OriginalClient):
135135
response = client.create_asset(**request_data)
136136
assert response["data"]["uid"] is not None
137137

138-
def test_create_asset_with_deprecated_client_id(self, client: OriginalClient):
139-
asset_name = get_random_string(8)
140-
asset_data = {
141-
"name": asset_name,
142-
"unique_name": True,
143-
"image_url": "https://example.com/image.png",
144-
"store_image_on_ipfs": False,
145-
"attributes": [
146-
{"trait_type": "Eyes", "value": "Green"},
147-
{"trait_type": "Hair", "value": "Black"},
148-
],
149-
}
150-
request_data = {
151-
"data": asset_data,
152-
"user_uid": TEST_APP_USER_UID,
153-
"client_id": asset_name,
154-
"collection_uid": TEST_APP_COLLECTION_UID,
155-
}
156-
response = client.create_asset(**request_data)
157-
assert response["data"]["uid"] is not None
158-
159-
def test_create_asset_with_no_client_id(self, client: OriginalClient):
160-
asset_name = get_random_string(8)
161-
asset_data = {
162-
"name": asset_name,
163-
"unique_name": True,
164-
"image_url": "https://example.com/image.png",
165-
"store_image_on_ipfs": False,
166-
"attributes": [
167-
{"trait_type": "Eyes", "value": "Green"},
168-
{"trait_type": "Hair", "value": "Black"},
169-
],
170-
}
171-
request_data = {
172-
"data": asset_data,
173-
"user_uid": TEST_APP_USER_UID,
174-
"collection_uid": TEST_APP_COLLECTION_UID,
175-
}
176-
response = client.create_asset(**request_data)
177-
assert response["data"]["uid"] is not None
178-
179138
def test_get_asset(self, client: OriginalClient):
180139
response = client.get_asset(TEST_ASSET_UID)
181140
assert response["data"]["uid"] == TEST_ASSET_UID
@@ -289,7 +248,7 @@ def test_edit_asset(self, client: OriginalClient):
289248
request_data = {
290249
"data": asset_data,
291250
"user_uid": TEST_APP_USER_UID,
292-
"client_id": asset_name,
251+
"asset_external_id": asset_name,
293252
"collection_uid": TEST_APP_COLLECTION_UID,
294253
}
295254
asset_response = client.create_asset(**request_data)
@@ -327,7 +286,7 @@ def test_full_create_transfer_burn_asset_flow(self, client: OriginalClient):
327286
request_data = {
328287
"data": asset_data,
329288
"user_uid": TEST_APP_USER_UID,
330-
"client_id": asset_name,
289+
"asset_external_id": asset_name,
331290
"collection_uid": TEST_APP_COLLECTION_UID,
332291
}
333292
asset_response = client.create_asset(**request_data)

0 commit comments

Comments
 (0)