Skip to content

Lost Issues/Events After upgrade from version 9.0 to 21.5 #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bergpb opened this issue Jan 11, 2022 · 10 comments
Closed

Lost Issues/Events After upgrade from version 9.0 to 21.5 #1252

bergpb opened this issue Jan 11, 2022 · 10 comments

Comments

@bergpb
Copy link

bergpb commented Jan 11, 2022

Version

9.0

Steps to Reproduce

  1. Have a Sentry in version 9.0 with projects and a good amount of issues,
  2. Start the upgrade from version 9.0 to 21.5 (9.0 > 9.1.2 > 20.12.1 > 21.5) using hard steps,
    1. I'm using version 20.12.1 because I have some problems with migrations: https://forum.sentry.io/t/migration-errors-9-1-2-to-21-6-1-project-object-has-no-attribute-get-option/14279
  3. After finishing the upgrade check issues for every project

Expected Result

After the upgrade is expected that all issues from version 9.0 are migrated correctly to version 21.5

Actual Result

Some issues were lost after the upgrade.

  1. The cleanup service is removed in the docker-compose file,
  2. The variable SENTRY_EVENT_RETENTION_DAYS is increased to a value more than necessary to test if another service can remove issues too. Ex: SENTRY_EVENT_RETENTION_DAYS=3560

Previous discussion in General Thread:
#1175 (comment)
#1239 (comment)

@brunis
Copy link

brunis commented Jan 12, 2022

When you write 9.1, do you mean 9.1.2? ..hard stop is supposed to go:
<your.sentry.version> -> 9.1.2 -> 21.5.0 -> 21.6.3 -> latest
https://develop.sentry.dev/self-hosted/releases/

@bergpb
Copy link
Author

bergpb commented Jan 12, 2022

Yes @brunis, I'm 9.1.2 like described in hard stops.

@chadwhitacre
Copy link
Member

Hrm, should we fold this into #1240? 👀

@brunis
Copy link

brunis commented Jan 14, 2022

Hrm, should we fold this into #1240? 👀

You should fix it, and not worry so much about folding..

@brunis
Copy link

brunis commented Jan 17, 2022

Hrm, should we fold this into #1240? 👀

But yes, if @bergpb documents that his events disappear in the 9.1.2 -> 10.0.0 upgrade, then i guess we have a good reason to.
And an even better reason to look into it and fix it :)

@chadwhitacre
Copy link
Member

Sounds good. @bergpb Let's move over to #1240 ...

@chadwhitacre
Copy link
Member

Sorry for the flail! Reopening because I now see a different actual result here than on #1240:

After finishing the upgrade check issues for every project
Some issues were lost after the upgrade.

Can you remind me how you are checking issues? I think this might be in one of the previous threads ... 🐭

@bergpb
Copy link
Author

bergpb commented Jan 26, 2022

Hey @chadwhitacre I'm created a simple python script and made requests to Sentry API to compare the issues between versions 9 and 21.5!
I'm algo got some of these values and checked manually to verify if script work's like expected.

@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@chadwhitacre
Copy link
Member

@bergpb And when you compare the issues what patterns do you see? What hypotheses have you generated and tested based on these patterns?

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants