Update GH actions run vars (#3013)

Author: denrase

.github/actions/flutter-test/action.yml

@@ -36,11 +36,18 @@ runs:
       if: matrix.target == 'linux' || matrix.target == 'windows' || matrix.target == 'macos'
       working-directory: ${{ inputs.directory }}
       shell: bash
+      env:
+        INPUT_DIRECTORY: ${{ inputs.directory }}
       run: |
-        testCmd="flutter test ${{ (inputs.directory == 'isar' && '-j 1') || '' }} --test-randomize-ordering-seed=random"
+        if [[ "$INPUT_DIRECTORY" == 'isar' ]]; then
+          testCmd="flutter test -j 1 --test-randomize-ordering-seed=random"
+        else
+          testCmd="flutter test --test-randomize-ordering-seed=random"
+        fi
+        
         if ${{ (matrix.target == 'linux' && matrix.sdk == 'stable' && 'true') || 'false' }} ; then
           $testCmd --coverage
-          if [[ '${{ inputs.directory }}' == 'flutter' ]] ; then
+          if [[ "$INPUT_DIRECTORY" == 'flutter' ]] ; then
             dart run remove_from_coverage -f coverage/lcov.info -r 'binding.dart'
           fi
         else

.github/workflows/analyze.yml

@@ -37,10 +37,16 @@ jobs:
       - uses: subosito/flutter-action@395322a6cded4e9ed503aebd4cc1965625f8e59a # [email protected]
         if: ${{ inputs.sdk == 'flutter' }}
 
-      - run: ${{ inputs.sdk }} pub get
-      - run: ${{ inputs.sdk }} pub get
+      - run: dart pub get
+        if: ${{ inputs.sdk == 'dart' }}
+
+      - run: flutter pub get
+        if: ${{ inputs.sdk == 'flutter' }}
+
+      - run: flutter pub get
         if: ${{ inputs.package == 'flutter' }}
         working-directory: flutter/microbenchmarks
+
       - run: dart format --set-exit-if-changed ./
 
       - name: dart analyze
@@ -77,10 +83,11 @@ jobs:
         env:
           TOTAL: ${{ steps.analysis.outputs.total }}
           TOTAL_MAX: ${{ steps.analysis.outputs.total_max }}
+          PANA_THRESHOLD: ${{ inputs.panaThreshold }}
         run: |
           PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX ))
-          if (( $PERCENTAGE < ${{ inputs.panaThreshold }} ))
+          if (( $PERCENTAGE < $PANA_THRESHOLD ))
           then
-            echo "Score too low ($PERCENTAGE % is less than the expected ${{ inputs.panaThreshold }} %)!"
+            echo "Score too low ($PERCENTAGE % is less than the expected $PANA_THRESHOLD %)!"
             exit 1
           fi

.github/workflows/diagrams.yml

@@ -69,4 +69,6 @@ jobs:
         # we need to pass the current branch, otherwise we can't commit the changes.
         # GITHUB_HEAD_REF is the name of the head branch. GitHub Actions only sets this for PRs.
       - name: Commit & push
-        run: ./scripts/commit-code.sh ${{ steps.extract_branch.outputs.branch }} "Update class diagrams"
+        run: ./scripts/commit-code.sh "$BRANCH_NAME" "Update class diagrams"
+        env:
+          BRANCH_NAME: ${{ steps.extract_branch.outputs.branch }}

.github/workflows/flutter-symbols.yml

@@ -45,10 +45,11 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ github.token }}
 
-      - run: dart run bin/flutter_symbol_collector.dart --version=${{ inputs.flutter_version || '3.*.*' }}
+      - run: dart run bin/flutter_symbol_collector.dart --version="$FLUTTER_VERSION"
         timeout-minutes: 300
         env:
           GITHUB_TOKEN: ${{ github.token }}
+          FLUTTER_VERSION: ${{ inputs.flutter_version || '3.*.*' }}
 
       - name: Upload updated status cache of processed files
         uses: actions/upload-artifact@v4

.github/workflows/flutter_test.yml

@@ -157,7 +157,9 @@ jobs:
         # Should be OK because it will likely be removed after switching to FFI (see https://github.com/getsentry/sentry-dart/issues/1444).
         if: ${{ matrix.target != 'macos' }}
         working-directory: ./flutter/example/${{ matrix.target }}
-        run: xcodebuild test -workspace Runner.xcworkspace -scheme Runner -configuration Debug -destination "platform=${{ steps.device.outputs.platform }}" -allowProvisioningUpdates CODE_SIGNING_ALLOWED=NO
+        run: xcodebuild test -workspace Runner.xcworkspace -scheme Runner -configuration Debug -destination "platform=$DEVICE_PLATFORM" -allowProvisioningUpdates CODE_SIGNING_ALLOWED=NO
+        env:
+          DEVICE_PLATFORM: ${{ steps.device.outputs.platform }}
 
   test-web:
     runs-on: ubuntu-latest

.github/workflows/format-and-fix.yml

@@ -51,4 +51,6 @@ jobs:
         # we need to pass the current branch, otherwise we can't commit the changes.
         # GITHUB_HEAD_REF is the name of the head branch. GitHub Actions only sets this for PRs.
       - name: Commit & push
-        run: ./scripts/commit-code.sh ${{ steps.extract_branch.outputs.branch }} "Format & fix code"
+        run: ./scripts/commit-code.sh "$BRANCH_NAME" "Format & fix code"
+        env:
+          BRANCH_NAME: ${{ steps.extract_branch.outputs.branch }}