Skip to content

Commit 4576880

Browse files
Denis AndrašecDenis Andrašec
Denis Andrašec
authored and
Denis Andrašec
committed
rename file, introduce remaining enum cases
1 parent 93c8cea commit 4576880

File tree

5 files changed

+47
-27
lines changed

5 files changed

+47
-27
lines changed

dart/lib/src/client_reports/client_report_recorder.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import 'package:meta/meta.dart';
33
import '../sentry_options.dart';
44
import 'client_report.dart';
55
import 'discarded_event.dart';
6-
import 'outcome.dart';
6+
import 'discard_reason.dart';
77
import '../transport/data_category.dart';
88

99
@internal
Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
import 'package:meta/meta.dart';
2+
3+
/// A reason that defines why events were lost, see
4+
/// https://develop.sentry.dev/sdk/client-reports/#envelope-item-payload.
5+
@internal
6+
enum DiscardReason {
7+
beforeSend,
8+
eventProcessor,
9+
sampleRate,
10+
networkError,
11+
queueOverflow,
12+
cacheOverflow,
13+
rateLimitBackoff,
14+
}
15+
16+
extension OutcomeExtension on DiscardReason {
17+
String toStringValue() {
18+
switch (this) {
19+
case DiscardReason.beforeSend:
20+
return 'before_send';
21+
case DiscardReason.eventProcessor:
22+
return 'event_processor';
23+
case DiscardReason.sampleRate:
24+
return 'sample_rate';
25+
case DiscardReason.networkError:
26+
return 'network_error';
27+
case DiscardReason.queueOverflow:
28+
return 'queue_overflow';
29+
case DiscardReason.cacheOverflow:
30+
return 'cache_overflow';
31+
case DiscardReason.rateLimitBackoff:
32+
return 'ratelimit_backoff';
33+
}
34+
}
35+
}

dart/lib/src/client_reports/discarded_event.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import 'package:meta/meta.dart';
22

3-
import 'outcome.dart';
3+
import 'discard_reason.dart';
44
import '../transport/data_category.dart';
55

66
@internal

dart/lib/src/client_reports/outcome.dart

Lines changed: 0 additions & 15 deletions
This file was deleted.

dart/test/client_reports/client_report_recorder_test.dart

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import 'package:sentry/src/client_reports/outcome.dart';
1+
import 'package:sentry/src/client_reports/discard_reason.dart';
22
import 'package:sentry/src/transport/data_category.dart';
33
import 'package:test/test.dart';
44

@@ -23,7 +23,7 @@ void main() {
2323
test('flush returns client report with current date', () {
2424
final sut = fixture.getSut();
2525

26-
sut.recordLostEvent(DiscardReason.ratelimitBackoff, DataCategory.error);
26+
sut.recordLostEvent(DiscardReason.rateLimitBackoff, DataCategory.error);
2727

2828
final clientReport = sut.flush();
2929

@@ -33,25 +33,25 @@ void main() {
3333
test('record lost event', () {
3434
final sut = fixture.getSut();
3535

36-
sut.recordLostEvent(DiscardReason.ratelimitBackoff, DataCategory.error);
37-
sut.recordLostEvent(DiscardReason.ratelimitBackoff, DataCategory.error);
36+
sut.recordLostEvent(DiscardReason.rateLimitBackoff, DataCategory.error);
37+
sut.recordLostEvent(DiscardReason.rateLimitBackoff, DataCategory.error);
3838

3939
final clientReport = sut.flush();
4040

4141
final event = clientReport?.discardedEvents
4242
.firstWhere((element) => element.category == DataCategory.error);
4343

44-
expect(event?.reason, DiscardReason.ratelimitBackoff);
44+
expect(event?.reason, DiscardReason.rateLimitBackoff);
4545
expect(event?.category, DataCategory.error);
4646
expect(event?.quantity, 2);
4747
});
4848

4949
test('record outcomes with different categories recorded separately', () {
5050
final sut = fixture.getSut();
5151

52-
sut.recordLostEvent(DiscardReason.ratelimitBackoff, DataCategory.error);
52+
sut.recordLostEvent(DiscardReason.rateLimitBackoff, DataCategory.error);
5353
sut.recordLostEvent(
54-
DiscardReason.ratelimitBackoff, DataCategory.transaction);
54+
DiscardReason.rateLimitBackoff, DataCategory.transaction);
5555

5656
final clientReport = sut.flush();
5757

@@ -61,19 +61,19 @@ void main() {
6161
final second = clientReport?.discardedEvents
6262
.firstWhere((event) => event.category == DataCategory.transaction);
6363

64-
expect(first?.reason, DiscardReason.ratelimitBackoff);
64+
expect(first?.reason, DiscardReason.rateLimitBackoff);
6565
expect(first?.category, DataCategory.error);
6666
expect(first?.quantity, 1);
6767

68-
expect(second?.reason, DiscardReason.ratelimitBackoff);
68+
expect(second?.reason, DiscardReason.rateLimitBackoff);
6969
expect(second?.category, DataCategory.transaction);
7070
expect(second?.quantity, 1);
7171
});
7272

7373
test('calling flush multiple times returns null', () {
7474
final sut = fixture.getSut();
7575

76-
sut.recordLostEvent(DiscardReason.ratelimitBackoff, DataCategory.error);
76+
sut.recordLostEvent(DiscardReason.rateLimitBackoff, DataCategory.error);
7777

7878
sut.flush();
7979
final clientReport = sut.flush();

0 commit comments

Comments
 (0)