Skip to content

Commit 67a5716

Browse files
authored
fix: navigation breadcrumb with missing to crashes native (#2720)
* fix: navigation breadcrumb with missing `to` crashes native * chore: changelog
1 parent a7de7ef commit 67a5716

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66

77
- Disable `ScreenshotIntegration`, `WidgetsBindingIntegration` and `SentryWidget` in multi-view apps #2366 ([#2366](https://github.com/getsentry/sentry-dart/pull/2366))
88

9-
### Fixes
9+
### Fixes
1010

1111
- Reference to `SentryWidgetsFlutterBinding` in warning message in `FramesTrackingIntegration` ([#2704](https://github.com/getsentry/sentry-dart/pull/2704))
12+
- Replay video interuption if a `navigation` breadcrumb is missing `to` route info ([#2720](https://github.com/getsentry/sentry-dart/pull/2720))
1213

1314
### Deprecations
1415

flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterReplayBreadcrumbConverter.kt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,13 @@ class SentryFlutterReplayBreadcrumbConverter : DefaultReplayBreadcrumbConverter(
2828
"sentry.event" -> null
2929
"sentry.transaction" -> null
3030
"http" -> convertNetworkBreadcrumb(breadcrumb)
31-
"navigation" -> newRRWebBreadcrumb(breadcrumb)
31+
"navigation" -> {
32+
if (breadcrumb.data.containsKey("to") && breadcrumb.data["to"] is String) {
33+
newRRWebBreadcrumb(breadcrumb)
34+
} else {
35+
null
36+
}
37+
}
3238
"ui.click" ->
3339
newRRWebBreadcrumb(breadcrumb).apply {
3440
category = "ui.tap"

0 commit comments

Comments
 (0)