Skip to content

Renderer info doesn't differentiate between Impeller and Skia #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ueman opened this issue Nov 10, 2023 · 3 comments
Closed

Renderer info doesn't differentiate between Impeller and Skia #1719

ueman opened this issue Nov 10, 2023 · 3 comments

Comments

@ueman
Copy link
Collaborator

ueman commented Nov 10, 2023

Platform

Flutter Mobile

Obfuscation

Disabled

Debug Info

Disabled

Doctor

Irrelevant

Version

7.12.0

Steps to Reproduce

  1. cause error
  2. track error
  3. see Skia as renderer even when Impeller is used

Expected Result

Sentry can identify whether Skia or Impeller is used

Actual Result

It's always Skia

Are you willing to submit a PR?

None

@ueman
Copy link
Collaborator Author

ueman commented Nov 10, 2023

As seen in

return FlutterRenderer.skia;
Skia is hardcoded on dart:io platforms.

I guess it's probably to detect Impeller vs Skia based on the Info.plist flag on iOS. Maybe Android has something similar.

@buenaflor
Copy link
Contributor

Android should have a flag in AndroidManifest.xml. Is it possible to access flags from those during runtime?

@ueman
Copy link
Collaborator Author

ueman commented Nov 13, 2023

Android should have a flag in AndroidManifest.xml. Is it possible to access flags from those during runtime?

Yeah, but not from Flutter, just from the native parts. I would just remove it from the Flutter side for now (no info is better than wrong info) and then add the correct info in a later step.

@buenaflor buenaflor moved this from Needs Discussion to Needs Investigation in [DEPRECATED] Mobile SDKs Nov 23, 2023
@buenaflor buenaflor self-assigned this Nov 23, 2023
@buenaflor buenaflor moved this from Needs Investigation to Backlog in [DEPRECATED] Mobile SDKs Nov 23, 2023
@buenaflor buenaflor removed their assignment Dec 21, 2023
@kahest kahest closed this as completed Mar 10, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in [DEPRECATED] Mobile SDKs Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants