Skip to content

Improve test which check that integrations are added correctly #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ueman opened this issue Mar 29, 2021 · 1 comment
Closed

Improve test which check that integrations are added correctly #390

ueman opened this issue Mar 29, 2021 · 1 comment
Assignees
@ueman
Labels
testing

Comments

@ueman
Copy link
Collaborator

ueman commented Mar 29, 2021

We do have a lot of tests, which check that Integrations are added based on the platform. They work but they should be improved so that they don't rely on magic numbers.

See for some more context: #389 (comment)_
@ueman ueman mentioned this issue Mar 29, 2021
Merged
5 tasks
@ueman
Copy link
Collaborator Author

ueman commented Mar 30, 2021

In addition to this these options

sentry-dart/flutter/lib/src/sentry_flutter_options.dart

Line 173 in de0a2ce

void configureBreadcrumbTrackingForPlatform(
should probably migrated to the Platform class introduced by #389

@ueman ueman mentioned this issue Apr 19, 2021
Merged
5 tasks
@ueman ueman self-assigned this Apr 19, 2021
@ueman ueman closed this as completed Apr 26, 2021
@ueman ueman mentioned this issue Apr 26, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ueman ueman

Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ueman @bruno-garcia