From 519827b7658d6f7b33e7b2357200369e119b09ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Ueko=CC=88tter?= Date: Tue, 4 May 2021 10:38:46 +0200 Subject: [PATCH 1/7] Replace print() with log() --- CHANGELOG.md | 1 + dart/lib/src/protocol/sentry_level.dart | 26 +++++++++++++++++++++++++ dart/lib/src/sentry_options.dart | 8 +++++++- 3 files changed, 34 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 815424836c..32a1425321 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ * Fix: `dist` was read from `SENTRY_DSN`, now it's read from `SENTRY_DIST` (#442) * Bump: sentry-cocoa to v7.0.3 (#445) * Fix: Fix adding integrations on web (#450) +* Fix: Use `log()` instead of `print()` for SDK logging # 5.0.0 diff --git a/dart/lib/src/protocol/sentry_level.dart b/dart/lib/src/protocol/sentry_level.dart index a0e59e32fc..20b5e2823d 100644 --- a/dart/lib/src/protocol/sentry_level.dart +++ b/dart/lib/src/protocol/sentry_level.dart @@ -14,4 +14,30 @@ class SentryLevel { /// API name of the level as it is encoded in the JSON protocol. final String name; final int ordinal; + + /// For use with Dart's + /// [`log`](https://api.dart.dev/stable/2.12.4/dart-developer/log.html) + /// function. + /// These levels are inspired by + /// https://pub.dev/documentation/logging/latest/logging/Level-class.html + int toLogLevel() { + switch (this) { + // Level.SHOUT + case SentryLevel.fatal: + return 1200; + // Level.SEVERE + case SentryLevel.error: + return 1000; + // Level.SEVERE + case SentryLevel.warning: + return 900; + // Level.INFO + case SentryLevel.info: + return 8000; + // Level.CONFIG + case SentryLevel.debug: + return 700; + } + return 1200; + } } diff --git a/dart/lib/src/sentry_options.dart b/dart/lib/src/sentry_options.dart index c333887ee0..8447de8df0 100644 --- a/dart/lib/src/sentry_options.dart +++ b/dart/lib/src/sentry_options.dart @@ -1,4 +1,5 @@ import 'dart:async'; +import 'dart:developer'; import 'package:http/http.dart'; @@ -254,5 +255,10 @@ void noOpLogger(SentryLevel level, String message) {} /// A Logger that prints out the level and message void dartLogger(SentryLevel level, String message) { - print('[${level.name}] $message'); + log( + '[${level.name}] $message', + level: level.toLogLevel(), + name: '[sentry]', + time: getUtcDateTime(), + ); } From 90bb4f513ce110b8ec1ec58fed2bfd26b6a52a39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Uek=C3=B6tter?= Date: Tue, 4 May 2021 12:49:24 +0200 Subject: [PATCH 2/7] Update dart/lib/src/sentry_options.dart --- dart/lib/src/sentry_options.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dart/lib/src/sentry_options.dart b/dart/lib/src/sentry_options.dart index 8447de8df0..0cad18fb81 100644 --- a/dart/lib/src/sentry_options.dart +++ b/dart/lib/src/sentry_options.dart @@ -258,7 +258,7 @@ void dartLogger(SentryLevel level, String message) { log( '[${level.name}] $message', level: level.toLogLevel(), - name: '[sentry]', + name: 'sentry', time: getUtcDateTime(), ); } From 36ee4d743e60701a80dd6697725a15dc0400e16b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Uek=C3=B6tter?= Date: Tue, 4 May 2021 13:25:21 +0200 Subject: [PATCH 3/7] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 32a1425321..772782ec6f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,7 @@ * Fix: `dist` was read from `SENTRY_DSN`, now it's read from `SENTRY_DIST` (#442) * Bump: sentry-cocoa to v7.0.3 (#445) * Fix: Fix adding integrations on web (#450) -* Fix: Use `log()` instead of `print()` for SDK logging +* Fix: Use `log()` instead of `print()` for SDK logging (#453) # 5.0.0 From 3a3c5c09f6c5621976d8adaafc1c202f492d507b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Uek=C3=B6tter?= Date: Tue, 4 May 2021 13:55:22 +0200 Subject: [PATCH 4/7] Update dart/lib/src/protocol/sentry_level.dart --- dart/lib/src/protocol/sentry_level.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dart/lib/src/protocol/sentry_level.dart b/dart/lib/src/protocol/sentry_level.dart index 20b5e2823d..9853226199 100644 --- a/dart/lib/src/protocol/sentry_level.dart +++ b/dart/lib/src/protocol/sentry_level.dart @@ -33,7 +33,7 @@ class SentryLevel { return 900; // Level.INFO case SentryLevel.info: - return 8000; + return 800; // Level.CONFIG case SentryLevel.debug: return 700; From 55df6f13694fc7a6dc7cfac4025ea3c302d84177 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Uek=C3=B6tter?= Date: Tue, 4 May 2021 14:29:08 +0200 Subject: [PATCH 5/7] Update dart/lib/src/protocol/sentry_level.dart --- dart/lib/src/protocol/sentry_level.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dart/lib/src/protocol/sentry_level.dart b/dart/lib/src/protocol/sentry_level.dart index 9853226199..a10bb6c1db 100644 --- a/dart/lib/src/protocol/sentry_level.dart +++ b/dart/lib/src/protocol/sentry_level.dart @@ -38,6 +38,6 @@ class SentryLevel { case SentryLevel.debug: return 700; } - return 1200; + return 700; } } From f4200e33f2d9907777ef321cb021c11515322d7f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Ueko=CC=88tter?= Date: Fri, 7 May 2021 08:22:40 +0200 Subject: [PATCH 6/7] Rename function --- dart/lib/src/protocol/sentry_level.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dart/lib/src/protocol/sentry_level.dart b/dart/lib/src/protocol/sentry_level.dart index a10bb6c1db..a2524ce1ac 100644 --- a/dart/lib/src/protocol/sentry_level.dart +++ b/dart/lib/src/protocol/sentry_level.dart @@ -20,7 +20,7 @@ class SentryLevel { /// function. /// These levels are inspired by /// https://pub.dev/documentation/logging/latest/logging/Level-class.html - int toLogLevel() { + int toDartLogLevel() { switch (this) { // Level.SHOUT case SentryLevel.fatal: From fb88b5592be3d28f628cc1f8373e1609cfcca5fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Ueko=CC=88tter?= Date: Fri, 7 May 2021 08:23:35 +0200 Subject: [PATCH 7/7] Ups --- dart/lib/src/sentry_options.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dart/lib/src/sentry_options.dart b/dart/lib/src/sentry_options.dart index 0cad18fb81..c2de293292 100644 --- a/dart/lib/src/sentry_options.dart +++ b/dart/lib/src/sentry_options.dart @@ -257,7 +257,7 @@ void noOpLogger(SentryLevel level, String message) {} void dartLogger(SentryLevel level, String message) { log( '[${level.name}] $message', - level: level.toLogLevel(), + level: level.toDartLogLevel(), name: 'sentry', time: getUtcDateTime(), );