Enhancement: Replace print() with log() - #453
Merged
Merged
Conversation
ueman
commented
May 4, 2021
| @@ -254,5 +255,10 @@ void noOpLogger(SentryLevel level, String message) {} | |||
|
|
|||
| /// A Logger that prints out the level and message | |||
| void dartLogger(SentryLevel level, String message) { | |||
Collaborator
Author
There was a problem hiding this comment.
For v6 I'd like to add an error and stacktrace parameter to our loggers.
They can be passed to https://api.flutter.dev/flutter/dart-developer/log.html and look hopefully better
Codecov Report
@@ Coverage Diff @@
## main #453 +/- ##
==========================================
+ Coverage 89.98% 90.04% +0.05%
==========================================
Files 54 54
Lines 1698 1707 +9
==========================================
+ Hits 1528 1537 +9
Misses 170 170
Continue to review full report at Codecov.
|
ueman
commented
May 4, 2021
Collaborator
Author
|
Logs look like this now Well without the double brackets around |
ueman
marked this pull request as ready for review
May 4, 2021 10:54
ueman
commented
May 4, 2021
ueman
commented
May 4, 2021
marandaneto
reviewed
May 4, 2021
| /// function. | ||
| /// These levels are inspired by | ||
| /// https://pub.dev/documentation/logging/latest/logging/Level-class.html | ||
| int toLogLevel() { |
Contributor
There was a problem hiding this comment.
maybe we call toDartLogLevel instead?
marandaneto
reviewed
May 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Fixes #451
💚 How did you test it?
📝 Checklist
🔮 Next steps