Skip to content

[Go] Support For Go Gin Sampling Error Events #5071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
souredoutlook opened this issue May 24, 2022 · 4 comments · Fixed by #5090
Closed

[Go] Support For Go Gin Sampling Error Events #5071

souredoutlook opened this issue May 24, 2022 · 4 comments · Fixed by #5090

Comments

@souredoutlook
Copy link
Member

Core or SDK?

Platform/SDK

Which part? Which one?

Sampling Error Events

Description

The docs at this location:

https://docs.sentry.io/platforms/go/guides/gin/configuration/sampling/

Have a banner that suggest sampling error events is not supported however the text of the block and our basic options suggest that it is: https://docs.sentry.io/platforms/go/configuration/options/

Suggested Solution

Clarify what feature this banner is supposed to pointing to/make it more explicit.

@getsentry-release
Copy link
Contributor

Routing to @getsentry/team-web-sdk-backend for triage. ⏲️

@imatwawana
Copy link
Contributor

If this isn't supported, this block is working as intended. But if that's the case, we can always update the page so that section isn't displayed for Go. But let's get @getsentry/team-web-sdk-backend to confirm either way.

@sl0thentr0py
Copy link
Member

@imatwawana it is supported, let's remove the banner

@imatwawana
Copy link
Contributor

We should actually add the appropriate code snippet(s) then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants