-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Improve JS SDK Component Tracking Documentation #5582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for opening this! Let's have a meeting about naming conventions before you get too far into the work on this to make sure we avoid any titles that are going to cause us headaches down the road. |
Routing to @getsentry/team-web-sdk-frontend for triage. ⏲️ |
@imatwawana Sure, happy to chat about this. I've already started working on it but naming can be changed quickly. Also spent some time actually improving the content (which for Angular we really should do as I've realized). |
Uh oh!
There was an error while loading. Please reload this page.
Core or SDK?
Platform/SDK
Which part? Which one?
JS Framework SDKs (Angular, React, Vue, Svelte)
Description
This issue was extracted from #5470
Currently, our documentation on component tracking differs between SDKs that support the feature:
BrowserTracing
integration but for some reason, the code examples don't contain the Vue routing instrumentation (which would be in fact vue-specific but not an integration). In the "Getting Started" page, we show the correct configuration (e.g. for Vue 3). Perhaps this page needs some rework in general (might be a leftover from before we had a proper Vue SDK?)trackComponents
option is also mentioned in the "Getting Started" page. I think that's generally fine but from what I understand, "Getting started" should show how to get going and the other sections should show the advanced stuff, no?Suggested Solution
I would propose to rename the "Components" page in Angular and React to "Angular/React Features" and to try to make the naming as similar as possible. However, we need to find a middle ground because we can't only talk about component tracking in the docs, while the SDK code still uses terms like "tracing" and "profiling".
The changes for React and Angular shouldn't be too big. For Vue it's more work (we can also hold off from that). The goal would be to have one page that lists all [JS Framework]-SDK-specific features (meaning the ones we add on top of the base JS SDK), such as component tracking. I think overall, this would improve docs consistency across SDKs.
To Do
The text was updated successfully, but these errors were encountered: